Skip to content

Commit aa2bc60

Browse files
jan-safarmarcusmueller
authored andcommitted
channels: interpolate dist with M_PI, not 2*M_PI
The multiplication by 2 in the sinc() function argument appears to be a mistake. It, for example, results in signal paths with a delay of 0.5 sample time being completely ignored. https://en.wikipedia.org/wiki/Sinc_function
1 parent 2a5c880 commit aa2bc60

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gr-channels/lib/selective_fading_model_impl.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ namespace gr {
9595
gr_complex ff_H(d_faders[j]->next_sample());
9696
for(size_t k=0; k<d_taps.size(); k++){
9797
float dist = k-d_delays[j];
98-
float interpmag = d_sintable.sinc(2*M_PI*dist);
98+
float interpmag = d_sintable.sinc(M_PI*dist);
9999
d_taps[k] += ff_H * interpmag * d_mags[j];
100100
}
101101
}

0 commit comments

Comments
 (0)