Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing in package.json (@swagger-api/apidom-ns-json-schema-2019-09) #4705

Closed
mbwestphal opened this issue Feb 4, 2025 · 2 comments
Closed
Assignees
Labels
ApiDOM bug Something isn't working OpenAPI 3.1

Comments

@mbwestphal
Copy link

Q&A (please complete the following information)

  • OS: Debian Linux
  • Method of installation: pnpm
  • ApiDOM version: 1.0.0-beta.11

Describe the bug you're encountering

The package @swagger-api/apidom-ns-json-schema-2019-09 is being imported in pidom-ns-openapi-3-1 but it is not declared in the package.json.

~/apidom/packages/apidom-ns-openapi-3-1 (main)$ rg @swagger-api/apidom-ns-json-schema-2019-09
src/refractor/visitors/open-api-3-1/schema/$defsVisitor.ts
4:} from '@swagger-api/apidom-ns-json-schema-2019-09';

This produces errors when building with pnpm and hoist=false set in .npmrc.

✘ [ERROR] Could not resolve "@swagger-api/apidom-ns-json-schema-2019-09"

    ../node_modules/.pnpm/@[email protected]/node_modules/@swagger-api/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/$defsVisitor.mjs:1:61:
      1 │ import { $defsVisitor as $defsJSONSchema202012Visitor } from '@swagger-api/apidom-ns-json-schema-2019-09';
        ╵                                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expected behavior

All dependencies should be declared in package.json.

@char0n
Copy link
Member

char0n commented Feb 11, 2025

Hi @mbwestphal,

Thanks for noticing. Addressed in #4716

@char0n char0n added bug Something isn't working OpenAPI 3.1 ApiDOM labels Feb 11, 2025
@char0n char0n self-assigned this Feb 11, 2025
@char0n
Copy link
Member

char0n commented Feb 11, 2025

@char0n char0n closed this as completed Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ApiDOM bug Something isn't working OpenAPI 3.1
Projects
None yet
Development

No branches or pull requests

2 participants