Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require tokens in PR runs #3532

Closed
2 tasks
gfellerph opened this issue Sep 11, 2024 · 0 comments · Fixed by #4207
Closed
2 tasks

Don't require tokens in PR runs #3532

gfellerph opened this issue Sep 11, 2024 · 0 comments · Fixed by #4207
Assignees
@alionazherdetska
Labels
⚙️ setup Setup work for the repository or a new package 🛠️ workflows GitHub Actions
Milestone
Maintenance III

Comments

@gfellerph
Copy link
Member

Whenever a token is used in an action that runs on a PR from an outside contributor, we're not able to run this action (https://github.com/swisspost/design-system/actions/runs/10773823163/job/29972566219). This is because those actions run on the fork and not on our repo. Using combined actions which run on workflow_run solves this issue.

image

Tasks
Beta Give feedback
@gfellerph gfellerph added the ⚙️ setup Setup work for the repository or a new package label Sep 11, 2024
@gfellerph gfellerph mentioned this issue Sep 11, 2024
Closed
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Sep 25, 2024
@gfellerph gfellerph added this to the Maintenance III milestone Oct 8, 2024
@alionazherdetska alionazherdetska self-assigned this Dec 9, 2024
@alionazherdetska alionazherdetska moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Dec 9, 2024
This was linked to pull requests Dec 9, 2024
chore(github-action): updated deploy-documentation workflow #4192
Closed
fix(workflow): move create preview comment job to deploy documentation workflow #4207
Merged
@alionazherdetska alionazherdetska mentioned this issue Dec 11, 2024
Closed
@alionazherdetska alionazherdetska added the 🛠️ workflows GitHub Actions label Dec 11, 2024
@alionazherdetska alionazherdetska moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Dec 11, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alionazherdetska alionazherdetska

Labels
⚙️ setup Setup work for the repository or a new package 🛠️ workflows GitHub Actions
Projects
Design System Production Board
Status: 🚀 Done
Milestone
Maintenance III
2 participants
@gfellerph @alionazherdetska