Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Internet header package documentation disappears on tab click #4188

Closed
leagrdv opened this issue Dec 9, 2024 · 1 comment · Fixed by #4211
Closed

[bug]: Internet header package documentation disappears on tab click #4188

leagrdv opened this issue Dec 9, 2024 · 1 comment · Fixed by #4211
Assignees
@alionazherdetska
Labels
🐞 bug Something isn't working 📦 documentation Related to the @swisspost/design-system-documentation package v8 v9
Milestone
Maintenance III

Comments

@leagrdv
Copy link
Contributor

leagrdv commented Dec 9, 2024

Describe the bug
Upon clicking on a tab header in the "Instructions" page of the Internet Header package, all content disappears.
https://next.design-system.post.ch/?path=/docs/cfa21cbc-5f8d-4a42-8165-7f6ed20bf133--docs
@leagrdv leagrdv added the 🐞 bug Something isn't working label Dec 9, 2024
@leagrdv leagrdv added the v9 label Dec 10, 2024
@gfellerph gfellerph added this to the Maintenance III milestone Dec 11, 2024
@gfellerph gfellerph added the 📦 documentation Related to the @swisspost/design-system-documentation package label Dec 11, 2024
@gfellerph
Copy link
Member

Check event propagation so that the parent component does not react to nested tab events.

@gfellerph gfellerph added the v8 label Dec 11, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Dec 11, 2024
@alionazherdetska alionazherdetska self-assigned this Dec 11, 2024
@alionazherdetska alionazherdetska moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Dec 11, 2024
@alionazherdetska alionazherdetska linked a pull request Dec 11, 2024 that will close this issue
fix(component): fix tab isolation in nested post-tabs component #4211
Merged
@alionazherdetska alionazherdetska moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Dec 11, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alionazherdetska alionazherdetska

Labels
🐞 bug Something isn't working 📦 documentation Related to the @swisspost/design-system-documentation package v8 v9
Projects
Design System Production Board
Status: 🚀 Done
Milestone
Maintenance III
Development

Successfully merging a pull request may close this issue.

fix(component): fix tab isolation in nested post-tabs component swisspost/design-system
3 participants
@gfellerph @alionazherdetska @leagrdv