Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 4 compatibility #34

Closed
yurtesen opened this issue Dec 6, 2017 · 5 comments
Closed

Symfony 4 compatibility #34

yurtesen opened this issue Dec 6, 2017 · 5 comments

Comments

@yurtesen
Copy link

yurtesen commented Dec 6, 2017

Will you make a 4.x release to update composer.json so this can be installed with symfony 4?
@xabbuh
Copy link
Member

xabbuh commented Dec 7, 2017

The Acl component does not attract much attention nowadays. Would you like to open a PR?

@yurtesen
Copy link
Author

yurtesen commented Dec 7, 2017 •
edited
Loading

I really do not need the ACL component. But this currently stops me from using Sonata Admin with Symphony 4.
See: sonata-project/SonataDoctrineORMAdminBundle#771

It looks like security-acl composer.json already has necessary updates. Just needs a release?

@jaikdean
Copy link

jaikdean commented Dec 7, 2017

The latest master already allows Symfony 4 in composer.json and the unit tests all pass when using the latest stable versions.

@jaikdean
Copy link

jaikdean commented Jan 2, 2018

@fabpot ?

@jaikdean
Copy link

jaikdean commented Jan 3, 2018

This has been fixed by v3.0.1. Thanks Fabien!

@fabpot fabpot closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @jaikdean @yurtesen @xabbuh