Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] Improve invalid messages for form types #13954

Closed
xabbuh opened this issue Jul 10, 2020 · 3 comments
Closed

[Form] Improve invalid messages for form types #13954

xabbuh opened this issue Jul 10, 2020 · 3 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required)
Milestone
5.2

Comments

@xabbuh
Copy link
Member

xabbuh commented Jul 10, 2020

Q A
Feature PR symfony/symfony#30931
PR author(s) @hiddewie
Merged in 5.2-dev
@xabbuh xabbuh added the Form label Jul 10, 2020
@xabbuh xabbuh added this to the 5.2 milestone Jul 10, 2020
@wouterj
Copy link
Member

wouterj commented Oct 17, 2020

@xabbuh do you think there is something to do here? Nothing changes until you configure the option, and the deprecation notice already explains the option name. A possible solution is to add a little note about this for the updated form types, but I'm not sure if it's really needed.

@wouterj
Copy link
Member

wouterj commented Oct 17, 2020

Oh, we also need to update the relevant form types to document their new invalid_message default value.

@wouterj wouterj added actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Oct 17, 2020
@xabbuh
Copy link
Member Author

xabbuh commented Oct 18, 2020

I think documenting the new default value when you opt-in for it is the only relevant change needed here.

@TimoBakx TimoBakx mentioned this issue Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
5.2
Development

No branches or pull requests
2 participants
@wouterj @xabbuh