Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] Add support for key-type in XmlFileLoader #20167

Open
fabpot opened this issue Aug 27, 2024 · 3 comments
Open

[DependencyInjection] Add support for key-type in XmlFileLoader #20167

fabpot opened this issue Aug 27, 2024 · 3 comments

Comments

@fabpot
Copy link
Member

fabpot commented Aug 27, 2024

Q A
Feature PR symfony/symfony#58035
PR author(s) @alexandre-daubois
Merged in 7.2

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.2 branch in the symfony-docs repository.

Thank you! 😃

@fabpot fabpot added this to the 7.2 milestone Aug 27, 2024
@alexandre-daubois
Copy link
Contributor

Help wanted to understand where to add this bit. At first I thought of configuration.rst but it is only about arguments and properties, so I doesn't seem to be the right place.

@javiereguiluz
Copy link
Member

At first sight I'd also say that this should be documented in this section where we describe all the possible data types of service arguments: https://symfony.com/doc/current/configuration.html#configuration-parameters

@alexandre-daubois
Copy link
Contributor

That was my first choice also. But we actually only talk about service parameters, not arguments 🤔 Maybe it belongs to https://symfony.com/doc/current/service_container/injection_types.html?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants