Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpFoundation] Generate url-safe hashes for signed urls #20481

Closed
fabpot opened this issue Dec 18, 2024 · 1 comment
Closed

[HttpFoundation] Generate url-safe hashes for signed urls #20481

fabpot opened this issue Dec 18, 2024 · 1 comment
Labels
hasPR A Pull Request has already been submitted for this issue. HttpFoundation
Milestone
7.3

Comments

@fabpot
Copy link
Member

fabpot commented Dec 18, 2024

Q A
Feature PR symfony/symfony#59022
PR author(s) @valtzu
Merged in 7.3

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.3 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.3 milestone Dec 18, 2024
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jan 3, 2025
@OskarStark OskarStark mentioned this issue Jan 3, 2025
Merged
@javiereguiluz javiereguiluz mentioned this issue Jan 7, 2025
Merged
javiereguiluz added a commit that referenced this issue Jan 7, 2025
@javiereguiluz
minor #20508 [HttpFoundation] Generate url-safe hashes for signed url…
9cd4630 
…s (javiereguiluz)

This PR was merged into the 7.3 branch.

Discussion
----------

[HttpFoundation] Generate url-safe hashes for signed urls

Fixes #20481.

Commits
-------

1afb8eb [HttpFoundation] Generate url-safe hashes for signed urls
@javiereguiluz
Copy link
Member

Closed by #20508.

javiereguiluz added a commit that referenced this issue Jan 8, 2025
@javiereguiluz
minor #20538 [HttpFoundation] Mention issues with generated URL hashe…
2199b6b 
…s (javiereguiluz)

This PR was merged into the 6.4 branch.

Discussion
----------

[HttpFoundation] Mention issues with generated URL hashes

Related to #20481.

In #20508 we mention that "this problem no longer exist in 7.3". But, I think we should also mention that problem in all the branches before 7.3.

Commits
-------

357a3e9 [HttpFoundation] Mention issues with generated URL hashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. HttpFoundation
Projects
None yet
Milestone
7.3
Development

No branches or pull requests
3 participants
@fabpot @javiereguiluz @carsonbot