Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a visible link to the docs of each package #2309

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Oct 30, 2024

Q A
Bug fix? yes
New feature? no
Issues #2273
License MIT

I know that you mentioned that there's a work-in-progress effort to update some things in the current design (#2273 (comment)) but I think we should fix this issue quickly because it's a problem in many long package pages.

If you don't like the proposed changes here it's fine; let's iterate over them. Tell me what to fix or change and I'll do it. Thanks!

This is how this PR looks at the moment:

#SymfonyHackday :)

@javiereguiluz javiereguiluz added the Site ux.symfony.com label Oct 30, 2024
@carsonbot carsonbot added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Oct 30, 2024
@smnandre
Copy link
Member

I'll open a PR this week-end (ideally sunday afternoon) -- probably loosely based on the stimulus bundle page "menu", with some simplification in markup + CSS, and some things to help us bring the next chapter :)

But I see no problem to make this change in the meantime!

Do you think we could keep the current (flat) icon, with the color theme of the package ?

@smnandre smnandre removed the Bug Bug Fix label Oct 30, 2024
@smnandre
Copy link
Member

smnandre commented Nov 3, 2024

@javiereguiluz I'm on it and pretty confident i'll open the PR soon... (@kbond can confirm if needed)

But depending on tonight, i may miss the deadline by a day or two...
... as i have a clear roadmap on mind .. i needed to make some other changes :)

Poke me if you want to have an "avant-première" ;)

@Kocal
Copy link
Member

Kocal commented Dec 7, 2024

I'm working on it 👀

@Kocal
Copy link
Member

Kocal commented Dec 7, 2024

Since nothing moved since October/November, I still believe this PR is useful until we rewrite packages pages.

But, I've fixed the icon and its size, to be more consistent with the rest of the application:
image

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Dec 7, 2024
@Kocal
Copy link
Member

Kocal commented Dec 7, 2024

Thank you Javier.

@Kocal Kocal merged commit db6db8d into symfony:2.x Dec 7, 2024
3 of 4 checks passed
@javiereguiluz javiereguiluz deleted the doc_link branch December 7, 2024 12:04
@smnandre
Copy link
Member

@Kocal "Since nothing moved since October/November" ... this is not fair 😆 You were in the slack discussions about the redesign, and saw how the scope changed 😅

@Kocal
Copy link
Member

Kocal commented Dec 11, 2024

Of course, but I mean on the live website / pull-requests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site ux.symfony.com Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants