Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code internal: deprecated use of if (class(estimates) == "synthdid_estimate") #100

Open
MatthieuStigler opened this issue Feb 7, 2023 · 0 comments

Comments

@MatthieuStigler
Copy link

Several lines of code use if (class(estimates) == "synthdid_estimate"), whereas it is recommended instead to run if(inherits(estimates, "synthdid_estimate")) (this will even show up on a R CMD CHECK run. In my case, this will create an error when writing a supra class for a sDiD output.

Is there any chance you can simply change if (class(estimates) == "synthdid_estimate") to if(inherits(estimates, "synthdid_estimate")) in: synthdid/R/plot.R and synthdid/R/summary.R?

I am happy otherwise to submit a pull request, though three requests are pending approval since a few months?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant