You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Several lines of code use if (class(estimates) == "synthdid_estimate"), whereas it is recommended instead to run if(inherits(estimates, "synthdid_estimate")) (this will even show up on a R CMD CHECK run. In my case, this will create an error when writing a supra class for a sDiD output.
Is there any chance you can simply change if (class(estimates) == "synthdid_estimate") to if(inherits(estimates, "synthdid_estimate")) in: synthdid/R/plot.R and synthdid/R/summary.R?
I am happy otherwise to submit a pull request, though three requests are pending approval since a few months?
Thanks!
The text was updated successfully, but these errors were encountered:
Several lines of code use
if (class(estimates) == "synthdid_estimate")
, whereas it is recommended instead to runif(inherits(estimates, "synthdid_estimate"))
(this will even show up on a R CMD CHECK run. In my case, this will create an error when writing a supra class for a sDiD output.Is there any chance you can simply change
if (class(estimates) == "synthdid_estimate")
toif(inherits(estimates, "synthdid_estimate"))
in:synthdid/R/plot.R
andsynthdid/R/summary.R
?I am happy otherwise to submit a pull request, though three requests are pending approval since a few months?
Thanks!
The text was updated successfully, but these errors were encountered: