Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some linting? #43

Open
Jabster28 opened this issue Feb 24, 2021 · 1 comment
Open

add some linting? #43

Jabster28 opened this issue Feb 24, 2021 · 1 comment

Comments

@Jabster28
Copy link
Contributor

Jabster28 commented Feb 24, 2021

Is your feature request related to a problem? Please describe.
Lots of the PRs in this repo have a bunch of whitespace changes, because there aren't any linting rules. A lot of the code (e.g index.html and main.css) also has weird indentation that makes it hard to work with.

Describe the solution you'd like
Adding some code linters, such as ESLint and Prettier, maybe some pre-commit hooks or a PR github action too?

Describe alternatives you've considered
Maybe just a file or a bit in the readme that enforces a specific style, although that'd be much harder to maintain and enforce than having a package.json script to do it for you.

Additional context
Was planning to make a PR to fix the margin errors and the navbar clipping (but there's already a PR for that, haha) and noticed all of the weird indentation that's used and spare whitespace. Code would be a lot cleaner and PRs would be to review easier if we added an .eslintrc.json or something of the sorts.

airbnb has an npm package that has their own style guide, in case you don't want to spend too much time customising it

@Jabster28
Copy link
Contributor Author

I'd also be happy to make a PR with their style guide, should you be interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant