Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge this into gocraft/work #64

Open
austintaylor opened this issue Aug 5, 2021 · 4 comments
Open

Merge this into gocraft/work #64

austintaylor opened this issue Aug 5, 2021 · 4 comments

Comments

@austintaylor
Copy link

What do you think about merging this?

@taylorchu
Copy link
Owner

@austintaylor sgtm. but I don't have a good migration plan. do you have time to work on this?

@fgm
Copy link

fgm commented May 23, 2022

If that is the only issue, it may not be such a problem: not having compatibility is part of creating a major version. As long as there is a doc detailing all the API changes (not just the new API), I would say it is fine, even though it is not optimal. Better done than perfect.

@ericraio
Copy link

ericraio commented May 28, 2022

just put the old stuff on v1 branch and merge this into master, we'll get a ton more support for this

@taylorchu
Copy link
Owner

Another major problem is that I don't have the time for answering questions on github. In old gocraft/work, there will be a lot of existing users asking about how to migrate. This is a primary reason why I didn't do that yet.

This library is mature enough: we run 10-50 millions jobs with this a day internally. It covers various workloads with custom middleware: some are 1hour+ long-running jobs, and some require extremely small latency like 100ms. It is very battle-tested, but it lacks good docs and examples. I think you can use this library now even it is not merged to gocraft/work yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants