Build: Create a common location for shared makefile functionality

Author: beekhof

Makefile.common

@@ -0,0 +1,73 @@
+# Not all current distros support AM_V_P
+# https://www.gnu.org/software/automake/manual/html_node/Automake-silent_002drules-Option.html
+
+V ?= $(AM_DEFAULT_VERBOSITY)
+
+PCMK_V = $(pcmk__v_$(V))
+pcmk__v_0 = :
+pcmk__v_1 =
+
+PCMK_quiet = $(pcmk_quiet_$(V))
+pcmk_quiet_0 = >/dev/null 2>&1
+pcmk_quiet_1 = 
+
+AM_V_XSL = $(am__v_XSL_$(V))
+am__v_XSL_0 = @echo "  XSL     " $@;
+am__v_XSL_1 = 
+
+AM_V_MAN = $(am__v_MAN_$(V))
+am__v_MAN_0 = @echo "  MAN     " $@;
+am__v_MAN_1 = 
+
+AM_V_ASCII = $(am__v_ASCII_$(V))
+am__v_ASCII_0 = @echo "  ASCII   " $@;
+am__v_ASCII_1 = 
+
+AM_V_PUB = $(am__v_PUB_$(V))
+am__v_PUB_0 = @echo "  PUB     $@: $(DOCBOOK_FORMATS)";
+am__v_PUB_1 = 
+
+MAINTAINERCLEANFILES	= Makefile.in
+
+AM_CPPFLAGS		= -I$(top_builddir)/include -I$(top_srcdir)/include   \
+			  -I$(top_builddir)/libltdl -I$(top_srcdir)/libltdl
+
+if BUILD_HELP
+man8_MANS		= $(sbin_PROGRAMS:%=%.8) $(sbin_SCRIPTS:%=%.8)
+endif
+
+%.8:	%
+	chmod a+x $(abs_builddir)/$<
+	$(PCMK_V) $(abs_builddir)/$< --help
+	$(AM_V_MAN)$(HELP2MAN) --output $@ --no-info --section 8 --name "Part of the Pacemaker cluster resource manager" $(abs_builddir)/$<
+
+%.xml:  %
+	$(AM_V_GEN)$(abs_builddir)/$< metadata > $@
+
+%.dbook: %.xml
+	$(AM_V_XSL)$(XSLTPROC) --nonet --novalid --stringparam man.name $* $(DBOOK_OPTS) $(top_srcdir)/xml/ocf-meta2man.xsl $(abs_builddir)/$< > $(abs_builddir)/$@
+
+%.7:	%.dbook
+	$(AM_V_XSL)$(XSLTPROC) $(MANPAGE_XSLT) $(abs_builddir)/$< $(PCMK_quiet)
+
+# Build docbook from asciidoc because XML is a PITA to edit
+#
+# Build each chapter as a book (since the numbering isn't right for
+# articles and only books can have appendicies) and then strip out the
+# bits we don't want/need
+#
+%.xml:  %.txt
+	$(AM_V_ASCII)asciidoc -b docbook -a cli_name=$(ASCIIDOC_CLI_TYPE) -a $(ASCIIDOC_CLI_TYPE)=true -d book -o $@ $<
+	sed -i.sed 's///' $@
+	sed -i.sed 's///' $@                 # Fix line endings
+	sed -i.sed 's/\ lang="en"//' $@        # Never specify a language in the chapters
+	sed -i.sed 's/simpara/para/g' $@       # publican doesn't correctly render footnotes with simpara
+	sed -i.sed 's/.*<date>.*//g' $@	       # Remove dangling tag
+	sed -i.sed 's/.*preface>//g' $@        # Remove preface elements
+	sed -i.sed 's:<title></title>::g' $@   # Remove empty title
+	sed -i.sed 's/chapter/section/g' $@    # Chapters become sections, so that books can become chapters
+	sed -i.sed 's/<.*bookinfo.*>//g' $@    # Strip out bookinfo, we don't need it
+	-grep -qis "<appendix" $@ && sed -i.sed 's/.*book>//' $@         # We just want the appendix tag
+	-grep -vqis "<appendix" $@ && sed -i.sed 's/book>/chapter>/g' $@ # Rename to chapter
+
+#	echo Rebuilt $@ from $<

cib/Makefile.am

@@ -15,10 +15,7 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 #
-MAINTAINERCLEANFILES    = Makefile.in
-
-INCLUDES        = -I$(top_builddir)/include  -I$(top_srcdir)/include  \
-		  -I$(top_builddir)/libltdl  -I$(top_srcdir)/libltdl
+include $(top_srcdir)/Makefile.common
 
 EXTRA_DIST	= cib.pam
 
@@ -32,15 +29,6 @@ COMMONLIBS	= $(top_builddir)/lib/common/libcrmcommon.la	\
 ## binary progs
 halib_PROGRAMS	= cib cibmon
 
-if BUILD_HELP
-man8_MANS =
-%.8:	%
-	echo "  MAN      $@"
-	chmod a+x $(top_builddir)/cib/$<
-	if $(AM_V_P); then $(top_builddir)/cib/$< --help; fi
-	$(HELP2MAN) --output $@ --no-info --section 8 --name "Part of the Pacemaker cluster resource manager" $(top_builddir)/cib/$<
-endif
-
 ## SOURCES
 noinst_HEADERS          = callbacks.h cibio.h cibmessages.h common.h notify.h
 

crmd/Makefile.am

@@ -15,10 +15,7 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 #
-MAINTAINERCLEANFILES    = Makefile.in
-
-INCLUDES        = -I$(top_builddir)/include -I$(top_srcdir)/include	\
-		-I$(top_builddir)/libltdl   -I$(top_srcdir)/libltdl
+include $(top_srcdir)/Makefile.common
 
 halibdir	= $(CRM_DAEMON_DIR)
 
@@ -50,29 +47,14 @@ crmd_LDADD	= $(top_builddir)/lib/fencing/libstonithd.la		\
 		$(top_builddir)/lib/services/libcrmservice.la		\
 		$(top_builddir)/lib/lrmd/liblrmd.la		\
 		$(CLUSTERLIBS)
+
 if BUILD_XML_HELP
 man7_MANS =	crmd.7
-
-pcmk_quiet = $(pcmk_quiet_@AM_V@)
-pcmk_quiet_ = $(pcmk_quiet_@AM_DEFAULT_V@)
-pcmk_quiet_0 = 2>/dev/null
-
-%.xml:	%
-	echo "  DBOOK    $@"
-	$(top_builddir)/crmd/$< metadata | $(XSLTPROC) --nonet --novalid --stringparam man.name $< $(top_srcdir)/xml/ocf-meta2man.xsl - > $(top_builddir)/crmd/$@
-
-%.7:	%.xml
-	echo "  MAN      $@"
-	$(XSLTPROC) $(MANPAGE_XSLT) $(top_builddir)/crmd/$< $(pcmk_quiet)
 endif
 
 clean-generic:
 	rm -f *.log *.debug *.xml *~
 
-install-exec-local:
-
-uninstall-local:
-
 graphs:	fsa_inputs.png fsa_inputs_by_action.png fsa_actions_by_state.png
 
 %.png: %.dot

extra/resources/Makefile.am

@@ -17,7 +17,8 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 #
-MAINTAINERCLEANFILES = Makefile.in
+include $(top_srcdir)/Makefile.common
+
 EXTRA_DIST		= $(ocf_SCRIPTS)
 
 ocfdir		    = @OCF_RA_DIR@/pacemaker
@@ -35,20 +36,14 @@ ocf_SCRIPTS	     =  ClusterMon 	\
 			SystemHealth \
 			remote
 
-pcmk_quiet = $(pcmk_quiet_@AM_V@)
-pcmk_quiet_ = $(pcmk_quiet_@AM_DEFAULT_V@)
-pcmk_quiet_0 = 2>/dev/null
-
 if BUILD_XML_HELP
+
 man7_MANS = $(ocf_SCRIPTS:%=ocf_pacemaker_%.7)
+DBOOK_OPTS = --stringparam command.prefix ocf_pacemaker_ --stringparam variable.prefix OCF_RESKEY_ --param man.vol 7
 
-%.xml:	%
-	echo "  DBOOK    $@"
-	OCF_FUNCTIONS=/dev/null OCF_ROOT=$(OCF_ROOT_DIR) sh $(top_srcdir)/extra/resources/$< meta-data | $(XSLTPROC) --nonet --novalid --stringparam command.prefix ocf_pacemaker_ --stringparam variable.prefix OCF_RESKEY_ --param man.vol 7 $(top_srcdir)/xml/ocf-meta2man.xsl - > $@ $(pcmk_quiet)
+ocf_pacemaker_%.xml:  %
+	$(AM_V_GEN)OCF_FUNCTIONS=/dev/null OCF_ROOT=$(OCF_ROOT_DIR) sh $(abs_builddir)/$< meta-data > $@
 
-ocf_pacemaker_%.7:	%.xml
-	echo "  MAN      $@"
-	$(XSLTPROC) $(MANPAGE_XSLT) $(top_builddir)/extra/resources/$< $(pcmk_quiet)
 endif
 
 clean-generic:

fencing/Makefile.am

@@ -15,7 +15,7 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 #
-MAINTAINERCLEANFILES = Makefile.in
+include $(top_srcdir)/Makefile.common
 
 SUBDIRS =
 
@@ -31,31 +31,8 @@ sbin_SCRIPTS   = fence_legacy fence_pcmk
 
 noinst_HEADERS = internal.h
 
-man7_MANS      =
-man8_MANS      =
-
-pcmk_quiet = $(pcmk_quiet_@AM_V@)
-pcmk_quiet_ = $(pcmk_quiet_@AM_DEFAULT_V@)
-pcmk_quiet_0 = 2>/dev/null
-
 if BUILD_XML_HELP
-man7_MANS +=	stonithd.7
-stonithd.xml:	stonithd
-	echo "  DBOOK    $@"
-	$(top_builddir)/fencing/$< metadata | $(XSLTPROC) --nonet --novalid --stringparam man.name $< $(top_srcdir)/xml/ocf-meta2man.xsl - > $(top_builddir)/fencing/$@
-
-stonithd.7:	stonithd.xml
-	echo "  MAN      $@"
-	$(XSLTPROC) $(MANPAGE_XSLT) $(top_builddir)/fencing/$< $(pcmk_quiet)
-endif
-
-if BUILD_HELP
-man8_MANS +=	$(sbin_PROGRAMS:%=%.8) $(sbin_SCRIPTS:%=%.8)
-%.8:	%
-	echo "  MAN      $@"
-	chmod a+x $(top_builddir)/fencing/$<
-	if $(AM_V_P); then $(top_builddir)/fencing/$< --help; fi
-	$(HELP2MAN) --output $@ --no-info --section 8 --name "Part of the Pacemaker cluster resource manager" $(top_builddir)/fencing/$<
+man7_MANS =	stonithd.7
 endif
 
 stonith_test_SOURCES	= test.c

lrmd/Makefile.am

@@ -15,7 +15,7 @@
 # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 #
 
-MAINTAINERCLEANFILES = Makefile.in
+include $(top_srcdir)/Makefile.common
 
 testdir			= $(datadir)/$(PACKAGE)/tests/lrmd
 test_SCRIPTS		= regression.py
@@ -31,16 +31,6 @@ if BUILD_SYSTEMD
 systemdunit_DATA = pacemaker_remote.service
 endif
 
-if BUILD_HELP
-man8_MANS =	$(sbin_PROGRAMS:%=%.8)
-endif
-
-%.8:	%
-	echo "  MAN      $@"
-	chmod a+x $(top_builddir)/lrmd/$<
-	if $(AM_V_P); then $(top_builddir)/lrmd/$< --help; fi
-	$(HELP2MAN) --output $@ --no-info --section 8 --name "Part of the Pacemaker cluster resource manager" $(top_builddir)/lrmd/$<
-
 lrmd_SOURCES	= main.c lrmd.c
 lrmd_LDADD		= $(top_builddir)/lib/common/libcrmcommon.la	\
 			$(top_builddir)/lib/services/libcrmservice.la \

mcp/Makefile.am

@@ -15,20 +15,14 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 #
-MAINTAINERCLEANFILES    = Makefile.in
+include $(top_srcdir)/Makefile.common
 
 if BUILD_CS_SUPPORT
-INCLUDES                = -I$(top_builddir)/include -I$(top_srcdir)/include   \
-			  -I$(top_builddir)/libltdl -I$(top_srcdir)/libltdl
 
 initdir			= $(INITDIR)
 init_SCRIPTS		= pacemaker
 sbin_PROGRAMS		= pacemakerd
 
-if BUILD_HELP
-man8_MANS =	$(sbin_PROGRAMS:%=%.8)
-endif
-
 if BUILD_SYSTEMD
 systemdunit_DATA = pacemaker.service
 endif
@@ -41,18 +35,6 @@ pacemakerd_SOURCES	= pacemaker.c corosync.c
 pacemakerd_LDADD	= $(top_builddir)/lib/cluster/libcrmcluster.la $(top_builddir)/lib/common/libcrmcommon.la
 pacemakerd_LDFLAGS	= $(CLUSTERLIBS)
 
-%.8:	%
-	echo "  MAN      $@"
-	chmod a+x $(top_builddir)/mcp/$<
-	if $(AM_V_P); then $(top_builddir)/mcp/$< --help; fi
-	$(HELP2MAN) --output $@ --no-info --section 8 --name "Part of the Pacemaker cluster resource manager" $(top_builddir)/mcp/$<
-
 clean-generic:
 	rm -f *.log *.debug *.xml *~
-
-install-exec-local:
-
-uninstall-local:
-
-.PHONY: install-exec-hook
 endif

pengine/Makefile.am

@@ -15,11 +15,9 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 #
-MAINTAINERCLEANFILES    = Makefile.in
+include $(top_srcdir)/Makefile.common
 
-INCLUDES        = -I$(top_builddir)/include -I$(top_srcdir)/include	\
-		-I$(top_builddir)           -I$(top_srcdir)		\
-		-I$(top_builddir)/libltdl   -I$(top_srcdir)/libltdl
+AM_CPPFLAGS     += -I$(top_builddir) -I$(top_srcdir)
 
 halibdir	= $(CRM_DAEMON_DIR)
 
@@ -43,22 +41,8 @@ lib_LTLIBRARIES	= libpengine.la
 ## binary progs
 halib_PROGRAMS	= pengine
 
-pcmk_quiet = $(pcmk_quiet_@AM_V@)
-pcmk_quiet_ = $(pcmk_quiet_@AM_DEFAULT_V@)
-pcmk_quiet_0 = 2>/dev/null
-
-man7_MANS =
-
 if BUILD_XML_HELP
-man7_MANS +=	pengine.7
-
-pengine.xml:	pengine
-	echo "  DBOOK    $@"
-	$(top_builddir)/pengine/$< metadata | $(XSLTPROC) --nonet --novalid --stringparam man.name $< $(top_srcdir)/xml/ocf-meta2man.xsl - > $(top_builddir)/pengine/$@
-
-pengine.7:	pengine.xml
-	echo "  MAN      $@"
-	$(XSLTPROC) $(MANPAGE_XSLT) $(top_builddir)/pengine/$< $(pcmk_quiet)
+man7_MANS =	pengine.7
 endif
 
 ## SOURCES

tools/Makefile.am

@@ -15,10 +15,7 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 #
-MAINTAINERCLEANFILES    = Makefile.in
-
-INCLUDES                = -I$(top_builddir)/include -I$(top_srcdir)/include   \
-			  -I$(top_builddir)/libltdl -I$(top_srcdir)/libltdl
+include $(top_srcdir)/Makefile.common
 
 COMMONLIBS	= 							\
 		$(top_builddir)/lib/common/libcrmcommon.la		\
@@ -54,10 +51,6 @@ if BUILD_OPENIPMI_SERVICELOG
 sbin_PROGRAMS		+= ipmiservicelogd
 endif
 
-if BUILD_HELP
-man8_MANS =		$(sbin_PROGRAMS:%=%.8) $(sbin_SCRIPTS:%=%.8)
-endif
-
 ## SOURCES
 
 noinst_HEADERS		=
@@ -142,13 +135,6 @@ ipmiservicelogd_CFLAGS	= $(OPENIPMI_SERVICELOG_CFLAGS) $(SERVICELOG_CFLAGS)
 ipmiservicelogd_LDFLAGS	= $(top_builddir)/lib/common/libcrmcommon.la $(OPENIPMI_SERVICELOG_LIBS) $(SERVICELOG_LIBS)
 endif
 
-# https://www.gnu.org/software/automake/manual/html_node/Automake-silent_002drules-Option.html
-%.8:	% crm_attribute
-	echo "  MAN      $@"
-	chmod a+x $(top_builddir)/tools/$<
-	if $(AM_V_P); then $(top_builddir)/tools/$< --help; fi
-	PATH=$(top_builddir)/tools:$$PATH $(HELP2MAN) --output $@ --no-info --section 8 --name "Part of the Pacemaker cluster resource manager" $(top_builddir)/tools/$<
-
 clean-generic:
 	rm -f *.log *.debug *.xml *~