Skip to content

Commit 847142f

Browse files
authored
Support default package icon in offline scenarios (loic-sharma#435)
1 parent 8404130 commit 847142f

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

src/BaGet.UI/src/DisplayPackage/DisplayPackage.tsx

+3-4
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import SourceRepository from './SourceRepository';
1414
import { Versions, IPackageVersion } from './Versions';
1515

1616
import './DisplayPackage.css';
17+
import DefaultPackageIcon from "../default-package-icon-256x256.png";
1718

1819
interface IDisplayPackageProps {
1920
match: {
@@ -60,8 +61,6 @@ class DisplayPackage extends React.Component<IDisplayPackageProps, IDisplayPacka
6061
package: undefined,
6162
};
6263

63-
private readonly defaultIconUrl: string = 'https://www.nuget.org/Content/gallery/img/default-package-icon-256x256.png';
64-
6564
private id: string;
6665
private version?: string;
6766

@@ -210,7 +209,7 @@ class DisplayPackage extends React.Component<IDisplayPackageProps, IDisplayPacka
210209
<div className="row display-package">
211210
<aside className="col-sm-1 package-icon">
212211
<img
213-
src={this.state.package.iconUrl}
212+
src={this.state.package.iconUrl || DefaultPackageIcon}
214213
className="img-responsive"
215214
onError={this.loadDefaultIcon}
216215
alt="The package icon" />
@@ -307,7 +306,7 @@ class DisplayPackage extends React.Component<IDisplayPackageProps, IDisplayPacka
307306
}
308307

309308
private loadDefaultIcon = (e: React.SyntheticEvent<HTMLImageElement>) => {
310-
e.currentTarget.src = this.defaultIconUrl;
309+
e.currentTarget.src = DefaultPackageIcon;
311310
}
312311

313312
private normalizeVersion(version: string): string {

src/BaGet.UI/src/SearchResults.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { Checkbox, Dropdown, IDropdownOption, SelectableOptionMenuItemType } fro
44
import * as React from 'react';
55
import { Link } from 'react-router-dom';
66
import './SearchResults.css';
7+
import DefaultPackageIcon from "./default-package-icon-256x256.png";
78

89
interface ISearchResultsProps {
910
input: string;
@@ -32,7 +33,6 @@ interface ISearchResponse {
3233

3334
class SearchResults extends React.Component<ISearchResultsProps, ISearchResultsState> {
3435

35-
private readonly defaultIconUrl: string = 'https://www.nuget.org/Content/gallery/img/default-package-icon-256x256.png';
3636
private resultsController?: AbortController;
3737

3838
constructor(props: ISearchResultsProps) {
@@ -160,7 +160,7 @@ class SearchResults extends React.Component<ISearchResultsProps, ISearchResultsS
160160
<div key={value.id} className="row search-result">
161161
<div className="col-sm-1 hidden-xs hidden-sm">
162162
<img
163-
src={value.iconUrl || this.defaultIconUrl}
163+
src={value.iconUrl || DefaultPackageIcon}
164164
className="package-icon img-responsive"
165165
onError={this.loadDefaultIcon}
166166
alt="The package icon" />
@@ -272,7 +272,7 @@ class SearchResults extends React.Component<ISearchResultsProps, ISearchResultsS
272272
}
273273

274274
private loadDefaultIcon = (e: React.SyntheticEvent<HTMLImageElement>) => {
275-
e.currentTarget.src = this.defaultIconUrl;
275+
e.currentTarget.src = DefaultPackageIcon;
276276
}
277277

278278
private onChangePackageType = (e: React.FormEvent<HTMLDivElement>, option?: IDropdownOption) : void => {
Loading

0 commit comments

Comments
 (0)