Skip to content

Commit b347275

Browse files
authored
Display 'No dependencies' if group has no dependencies (loic-sharma#686)
1 parent fc3e10a commit b347275

File tree

3 files changed

+26
-10
lines changed

3 files changed

+26
-10
lines changed

src/BaGet.Core/Entities/PackageDependency.cs

+8
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,16 @@ public class PackageDependency
55
{
66
public int Key { get; set; }
77

8+
/// <summary>
9+
/// The dependency's package ID. Null if this is a dependency group without any dependencies.
10+
/// </summary>
811
public string Id { get; set; }
12+
13+
/// <summary>
14+
/// The dependency's package version. Null if this is a dependency group without any dependencies.
15+
/// </summary>
916
public string VersionRange { get; set; }
17+
1018
public string TargetFramework { get; set; }
1119

1220
public Package Package { get; set; }

src/BaGet.Web/Pages/Package.cshtml

+17-10
Original file line numberDiff line numberDiff line change
@@ -139,17 +139,24 @@ else
139139
</h4>
140140

141141
<ul class="list-unstyled dependency-group">
142-
@foreach (var dependency in group.Dependencies)
142+
@if (!group.Dependencies.Any())
143143
{
144-
<li>
145-
<a asp-page="Package"
146-
asp-route-id="@dependency.PackageId"
147-
asp-route-version="@null">
148-
@dependency.PackageId
149-
</a>
150-
151-
<span> @dependency.VersionSpec</span>
152-
</li>
144+
<li>No dependencies.</li>
145+
}
146+
else
147+
{
148+
@foreach (var dependency in group.Dependencies)
149+
{
150+
<li>
151+
<a asp-page="Package"
152+
asp-route-id="@dependency.PackageId"
153+
asp-route-version="@null">
154+
@dependency.PackageId
155+
</a>
156+
157+
<span> @dependency.VersionSpec</span>
158+
</li>
159+
}
153160
}
154161
</ul>
155162
}

src/BaGet.Web/Pages/Package.cshtml.cs

+1
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ private IReadOnlyList<DependencyGroupModel> ToDependencyGroups(Package package)
121121
{
122122
Name = PrettifyTargetFramework(group.Key),
123123
Dependencies = group
124+
.Where(d => d.Id != null)
124125
.Select(d => new DependencyModel
125126
{
126127
PackageId = d.Id,

0 commit comments

Comments
 (0)