Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make output the same for same RNG seed #60

Open
dandavison opened this issue Jan 11, 2024 · 0 comments
Open

[Feature Request] Make output the same for same RNG seed #60

dandavison opened this issue Jan 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dandavison
Copy link
Contributor

Ideally this would return the same value, but it doesn't currently (even after #57):

md5sum <(cargo run -- generate --explicit-seed=12345 2>/dev/null) <(cargo run -- generate --explicit-seed=12345 2>/dev/null)

I believe that this is due to the fact that serializing the WorkflowState HashMap yields keys and values in non-deterministic order. If so, it doesn't impact correctness, but it would still be reassuring to see the same output.

Fix this and add a test for same-seed-same-output.

@dandavison dandavison added the enhancement New feature or request label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant