Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Re-enable sharding checks for test_vector_conversion.cpp. #17806

Open
jjiangTT opened this issue Feb 10, 2025 · 0 comments
Open
Labels

Comments

@jjiangTT
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Re-enable additional sharding checks in test_vector_conversion.cpp.

Describe the solution you'd like
Sharding checks for sharding along height, width, and block currently fail with the shard_spec given in get_tensor_spec_with_memory(). New shard_specs compatible with these modes need to be written for these tests to work fully.

Describe alternatives you've considered
These three test suites have been disabled for now until a fix can be implemented. A square case that potentially checks out with sharding along all of these dimensions could be used as the shard_spec as well and can be explored.

Additional context
Interleaved and single-bank sharding still work.

@jjiangTT jjiangTT changed the title [Feature Request] ... [Feature Request] Re-enable sharding checks for test_vector_conversion.cpp. Feb 10, 2025
TT-BrianLiu added a commit that referenced this issue Feb 10, 2025
#17806: Skip incorrect sharded tests for ShardVectorConversionTests
TT-BrianLiu added a commit that referenced this issue Feb 10, 2025
#17806: Skip incorrect sharded tests for ShardVectorConversionTests
TT-BrianLiu added a commit that referenced this issue Feb 10, 2025
#17806: Skip incorrect sharded tests for ShardVectorConversionTests
avoraTT pushed a commit that referenced this issue Feb 11, 2025
#17806: Skip incorrect sharded tests for ShardVectorConversionTests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant