Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thecodrr/fdir
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: thecodrr/fdir
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: symlinks
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 9 files changed
  • 1 contributor

Commits on Apr 18, 2021

  1. feat: implement symlinks support 

    Symlinks are resolved using a combination of realpath & lstat.
Since fdir supports both sync & async APIs, I had to add a basic
queue system.

QUEUE:
Queue works by incrementing a counter everytime an async
call is made and decrementing it once it is done. Once the
counter === 0, it invokes the onQueueEmpty callback.

TODO:
1. There are no tests for the symlinks support.
2. Internal function naming in fdir is all over the place.
    @thecodrr
    thecodrr committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    a7f7f46 View commit details
    Browse the repository at this point in the history

  2. test: add tests for symlinks

    @thecodrr
    thecodrr committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    c2c22be View commit details
    Browse the repository at this point in the history

  3. docs: add docs for withSymlinks method

    @thecodrr
    thecodrr committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    dbe7249 View commit details
    Browse the repository at this point in the history
Loading