Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IAlbum.thumb optional #4

Closed
richardlnnr opened this issue Jun 26, 2018 · 4 comments
Closed

Make IAlbum.thumb optional #4

richardlnnr opened this issue Jun 26, 2018 · 4 comments

Comments

@richardlnnr
Copy link

Hi, thanks for this great lib.

Could you make the thumb property of class IAlbum optional?

Thanks.
@themyth92
Copy link
Owner

themyth92 commented Jun 27, 2018 •
edited
Loading

Can i have your use case here ? If no thumb, how can you click on the image ?

@richardlnnr
Copy link
Author

richardlnnr commented Jun 27, 2018 •
edited
Loading

I don't use thumb to display my image.
The src do that. I need display my images with the full quality.

The change is only for prevent this compiling error
image

@themyth92
Copy link
Owner

Hmm if that is the case, can you make the thumb url to equal src url ? So your thumbnail is just your src image ?

@themyth92
Copy link
Owner

Feel free to open if you still any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@themyth92 @richardlnnr