Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thirdweb-dev/insight
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.8-beta
Choose a base ref
...
head repository: thirdweb-dev/insight
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Dec 11, 2024

  1. Configuration menu
    Copy the full SHA
    1ebfa65 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2024

  1. Fix force range for reorg checks (#126)

    ### TL;DR
    Added block range validation and optimized block header queries to prevent unnecessary reorg checks.
    
    ### What changed?
    - Added validation to skip reorg checks when the most recent and last checked block numbers are equal
    - Modified the `LookbackBlockHeaders` query to include a lower bound on block numbers, creating a specific range for querying
    - Enhanced logging to better indicate when reorg checks are skipped
    
    ### How to test?
    1. Run the system with chain monitoring enabled
    2. Verify logs show skipped reorg checks when blocks are equal
    3. Confirm block header queries return results only within the specified range
    4. Validate that reorg detection still functions correctly for actual reorgs
    
    ### Why make this change?
    The previous implementation would perform unnecessary reorg checks when block numbers were identical and could potentially query more blocks than needed. These changes improve efficiency by avoiding redundant operations and limiting the query scope to only relevant block ranges.
    iuwqyir authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    996d70b View commit details
    Browse the repository at this point in the history
Loading