Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

where is the mask in cnn encoder? #12

Closed
littttttlebird opened this issue Mar 31, 2020 · 2 comments
Closed

where is the mask in cnn encoder? #12

littttttlebird opened this issue Mar 31, 2020 · 2 comments

Comments

@littttttlebird
Copy link

Why does the cnn encoder have no mask operation for the padding part in seq_len dim?

@gaotianyu1350
Copy link
Collaborator

CNN uses a max pooling and ReLU at the end, and padding part is all zero. So it is not necessary to use a mask.

@littttttlebird
Copy link
Author

the part of padding embedding is zero,but the conv filter bias will not always all to be zero(1, not initiall by zero,2,bp update),and it may bigger than other normal conv result,so, i think the mask is need。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants