Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many goroutines in commit phase affect performance #342

Open
youjiali1995 opened this issue Oct 20, 2021 · 3 comments
Open

Too many goroutines in commit phase affect performance #342

youjiali1995 opened this issue Oct 20, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@youjiali1995
Copy link
Contributor

@BusyJay found too many goroutines in commit phase affect performance a lot. The committer-concurrency is 1024. The region size on left side is smaller than right side.
image
It's not an apple to apple comparison, because larger region results in larger requests and batch, but the throughput of TiKV is the same.
image

Disregarding TiKV, too many goroutines affects GC, schedule of TSO goroutine and so on. We can improve it.
image
image

@youjiali1995 youjiali1995 added the enhancement New feature or request label Oct 20, 2021
@BusyJay
Copy link
Member

BusyJay commented Oct 20, 2021

One coroutine to one transaction is a more reasonable mapping to me.

@tiancaiamao
Copy link
Contributor

committer-concurrency is configurable and its default value is not 1024

@BusyJay
Copy link
Member

BusyJay commented Nov 8, 2021

committer-concurrency is configurable and its default value is not 1024

I don't think this configuration matters. It's possible to increase the transaction count while decrease this configuration to achieve similar regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants