Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent spurious error when muxer closes #369

Open
themighty1 opened this issue Oct 19, 2023 · 0 comments
Open

Prevent spurious error when muxer closes #369

themighty1 opened this issue Oct 19, 2023 · 0 comments

Comments

@themighty1
Copy link
Member

Currently at the end of the finalization the Verifier sends two messages:

  • a SignedSessionHeader
  • a signal for the Prover to shut down the muxer

The prover polls the associated futures here:

let (notary_encoder_seed, SignedSessionHeader { header, signature }) = futures::select_biased! {
res = notarize_fut => res?,
_ = ot_fut => return Err(OTShutdownError)?,
_ = mux_fut => return Err(std::io::Error::from(std::io::ErrorKind::UnexpectedEof))?,
};

It is possible that before notarize_fut finished processing SignedSessionHeader, the mux_fut will complete causing the prover to return an error.

We should find a way to prevent such a spurious error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant