Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job to run expensive integration tests #500

Closed
sinui0 opened this issue Jun 12, 2024 · 3 comments
Closed

Add CI job to run expensive integration tests #500

sinui0 opened this issue Jun 12, 2024 · 3 comments

Comments

@sinui0
Copy link
Member

sinui0 commented Jun 12, 2024

Some integration tests, such as in tls-mpc are expensive so they are marked ignore, but these still need to be run in CI.

@heeckhau
Copy link
Member

@sinui0 Do you want an extra CI step to run all ignored tests?

cargo test -- --ignored

, we can also include the ignored tests when we run the other tests:

cargo test -- --include-ignored

We could also introduce a expensive_tests feature, if we need to run only a few specific tests and ignore other tests.

@sinui0
Copy link
Member Author

sinui0 commented Jun 21, 2024

For now easiest is probably option 2, running ignored with the rest.

Might need option 1, because the ignored tests need to be run with release build

@yuroitaki
Copy link
Member

@sinui0 seems like this has been addressed by #537?

@sinui0 sinui0 closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants