Skip to content

Commit 31b375d

Browse files
authored
[INFRA] Update PR template to add test and user change question (apache#5486)
* [INFRA] Update PR template to add test and user change question * [INFRA] Update PR template to add test and user change question * update
1 parent 9c3cb88 commit 31b375d

File tree

1 file changed

+22
-3
lines changed

1 file changed

+22
-3
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+22-3
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,32 @@ Feel free to ping committers for the review!
1616
1717
-->
1818

19-
## Purpose of this pull request
19+
### Purpose of this pull request
2020

2121
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
2222

23-
## Check list
2423

25-
* [ ] Code changed are covered with tests, or it does not need tests for reason:
24+
### Does this PR introduce _any_ user-facing change?
25+
<!--
26+
Note that it means *any* user-facing change including all aspects such as the documentation fix.
27+
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
28+
If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
29+
If no, write 'No'.
30+
If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
31+
-->
32+
33+
34+
### How was this patch tested?
35+
<!--
36+
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
37+
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
38+
If tests were not added, please describe why they were not added and/or why it was difficult to add.
39+
If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
40+
-->
41+
42+
43+
### Check list
44+
2645
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
2746
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
2847
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs

0 commit comments

Comments
 (0)