Check if package.json exists while installing node modules

[tarunbhm]

The install_node_modules function does not check if the package.json file exists in the project directory. This function is used for foundry projects as well to support foundry projects with hardhat dependencies. But dry run fails for the pure foundry projects because they don't have a package.json file.

necessist/frameworks/src/ts_utils.rs

Lines 6 to 27 in b8ac93c

	pub fn install_node_modules(context: &LightContext) -> Result<()> {
	if context.root.join("node_modules").try_exists()? {
	return Ok(());
	}
	// smoelius: If a `yarn.lock` file exists, use `yarn`. Otherwise, default to `npm install`.
	let mut command = if context.root.join("yarn.lock").try_exists()? {
	Command::new("yarn")
	} else {
	let mut command = Command::new("npm");
	command.arg("install");
	command
	};
	command.current_dir(context.root.as_path());
	debug!("{:?}", command);
	let output = command.output()?;
	ensure!(output.status.success(), "{:#?}", output);
	Ok(())
	}

Adding a check if the package.json file exists will resolve this issue.

[0xPhaze]

Ran into the same issue:

necessist --reset
8782 candidates in 3 test files
test/Endpoint.t.sol: dry running
test/Endpoint.t.sol: Warning: dry run failed: Output {
    status: ExitStatus(
        unix_wait_status(
            65024,
        ),
    ),
    stdout: "",
    stderr: "npm ERR! code ENOENT\nnpm ERR! syscall open\nnpm ERR! path /Users/lain/git/audit/audit-orb/package.json\nnpm ERR! errno -2\nnpm ERR! enoent ENOENT: no such file or directory, open '/Users/lain/git/audit/audit-orb/package.json'\nnpm ERR! enoent This is related to npm not being able to find a file.\nnpm ERR! enoent \n\nnpm ERR! A complete log of this run can be found in:\nnpm ERR!     /Users/lain/.npm/_logs/2023-07-10T13_48_21_424Z-debug-0.log\n",
}
test/Rukh.t.sol: dry running
test/Rukh.t.sol: Warning: dry run failed: Output {
    status: ExitStatus(
        unix_wait_status(
            65024,
        ),
    ),
    stdout: "",
    stderr: "npm ERR! code ENOENT\nnpm ERR! syscall open\nnpm ERR! path /Users/lain/git/audit/audit-orb/package.json\nnpm ERR! errno -2\nnpm ERR! enoent ENOENT: no such file or directory, open '/Users/lain/git/audit/audit-orb/package.json'\nnpm ERR! enoent This is related to npm not being able to find a file.\nnpm ERR! enoent \n\nnpm ERR! A complete log of this run can be found in:\nnpm ERR!     /Users/lain/.npm/_logs/2023-07-10T13_48_21_623Z-debug-0.log\n",
test/Thunderbird.t.sol: dry running
test/Thunderbird.t.sol: Warning: dry run failed: Output {
    status: ExitStatus(
        unix_wait_status(
            65024,
        ),
    ),
    stdout: "",
    stderr: "npm ERR! code ENOENT\nnpm ERR! syscall open\nnpm ERR! path /Users/lain/git/audit/audit-orb/package.json\nnpm ERR! errno -2\nnpm ERR! enoent ENOENT: no such file or directory, open '/Users/lain/git/audit/audit-orb/package.json'\nnpm ERR! enoent This is related to npm not being able to find a file.\nnpm ERR! enoent \n\nnpm ERR! A complete log of this run can be found in:\nnpm ERR!     /Users/lain/.npm/_logs/2023-07-10T13_48_21_818Z-debug-0.log\n",

Created a small PR that implements the suggested check, thanks @tarunbhm

[smoelius]

Fixed by #580