Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add a section in LUA hooks explaining the required user permissions to execute them #7076

Open
N-o-Z opened this issue Nov 29, 2023 · 3 comments
Labels
contributor docs Improvements or additions to documentation

Comments

@N-o-Z
Copy link
Member

N-o-Z commented Nov 29, 2023

It is not clear - what are the implications of using LUA hooks with scripts on the ability of a user to perform an operation.
For example:
Say we configure a pre create branch LUA action that runs a certain script.
In addition we configure a user with permissions to create branch only (no read permission to objects)
In this scenario the user would not be able to create the branch since they will fail on the pre create branch hook due to permissions trying to read the script

@N-o-Z N-o-Z added docs Improvements or additions to documentation contributor labels Nov 29, 2023
@N-o-Z N-o-Z changed the title Docs: Added a section in LUA hooks explaining the required user permissions to execute them Docs: Add a section in LUA hooks explaining the required user permissions to execute them Nov 29, 2023
@nopcoder
Copy link
Contributor

@treeverse/product your input - do we need to enable hook execution regardless to the user's permissions? or document the required permissions based on the hook's operations.

Copy link

This issue is now marked as stale after 90 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.

@github-actions github-actions bot added the stale label Feb 29, 2024
@N-o-Z
Copy link
Member Author

N-o-Z commented Feb 29, 2024

@talSofer @ozkatz

@github-actions github-actions bot removed the stale label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants