Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report metric for GetObject TTFB #8503

Open
arielshaqed opened this issue Jan 15, 2025 · 1 comment
Open

Report metric for GetObject TTFB #8503

arielshaqed opened this issue Jan 15, 2025 · 1 comment
Labels
area/API Improvements or additions to the API good first issue Good for newcomers performance tech-debt

Comments

@arielshaqed
Copy link
Contributor

Currently GetObject reports duration for the entire GET. This is obviously useful, but equally useful is GetObject time to first byte (TTFB), which is insensitive to how the client reads the data. Obviously we cannot measure actual TTFB, but e.g. measuring until we start sending data should be close enough.

Required to provide SLOs for GetObject performance - otherwise network-distant clients ruin SLIs. Client performance should be measured on clients.

@arielshaqed arielshaqed added area/API Improvements or additions to the API performance tech-debt labels Jan 15, 2025
@itaiad200 itaiad200 added the good first issue Good for newcomers label Jan 22, 2025
@Isan-Rivkin
Copy link
Contributor

@arielshaqed can you please clarify what do you mean for we start sending data?

  • When data goes through us do you mean literally when client starts reading or it's good enough if we report right before the reader starts working?
  • Do we need that for get_object in S3 GW as well?
  • How do you expect to handle presigned requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API Improvements or additions to the API good first issue Good for newcomers performance tech-debt
Projects
None yet
Development

No branches or pull requests

3 participants