v1.1 - bugfixing, improvement

Author: try2codesecure

.classpath

@@ -4,5 +4,6 @@
 	<classpathentry kind="src" path="gen"/>
 	<classpathentry kind="con" path="com.android.ide.eclipse.adt.ANDROID_FRAMEWORK"/>
 	<classpathentry kind="con" path="com.android.ide.eclipse.adt.LIBRARIES"/>
+	<classpathentry exported="true" kind="con" path="com.android.ide.eclipse.adt.DEPENDENCIES"/>
 	<classpathentry kind="output" path="bin/classes"/>
 </classpath>

AndroidManifest.xml

@@ -2,7 +2,7 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.android.shellms"
     android:versionCode="1"
-    android:versionName="1.0" 
+    android:versionName="1.1" 
     android:installLocation="auto" >
 
     <uses-permission android:name="android.permission.SEND_SMS" />
@@ -28,6 +28,7 @@
                 <category android:name="android.intent.category.LAUNCHER" />
             </intent-filter>
         </activity>
+        
         <service
             android:enabled="true"
             android:name=".sendSMS"

README.md

@@ -4,9 +4,21 @@ ShellMS
 ShellMS - Android Debug Bridge Shell SMS Application
 
 ShellMS is the simplest and easiest ADB Shell Messaging Application.
-If you don't know what ADB or SDK is you defintely don't need this app.
+If you don't know what ADB or SDK is you definitely don't need this app.
 For the others it's useful tool to speed up messaging when you're working on your computer.
 
+Changelog:
+
+ IMPORTANT NOTE: If you're using a new cyanogenmod version =>
+	!! Please disable Privacy Guard for ShellMS !!
+(otherwise the app can't search in your phonebook for the contact-names)
+
+ v1.1 (20130704)
+	* fixed crash when sending long SMS
+	* improved shell template
+ v1.0 
+	* First Release
+
 License:
 
 Copyleft 2013, by Rainer [email protected]
@@ -56,9 +68,10 @@ Project's HomeSweetHome:
 
 Templates:
  * simple shell "template_sendsms.sh"
+ * for multiple contacts "template_sendsms_multiple-contacts.sh"
 
-Roadmap (planned improvements in next version):
- * improve the sendsms function => with reply value if it's sent correct
+Roadmap / TODO (planned improvements in the future):
+ * improve the sendsms function => with reply value if it's sent correct (BroadcastReceivers)
  * improve the serach for telephone numbers in address book
 
 Bug found? PLEASE report it =>

bin/AndroidManifest.xml

@@ -2,7 +2,7 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.android.shellms"
     android:versionCode="1"
-    android:versionName="1.0" 
+    android:versionName="1.1" 
     android:installLocation="auto" >
 
     <uses-permission android:name="android.permission.SEND_SMS" />
@@ -28,6 +28,7 @@
                 <category android:name="android.intent.category.LAUNCHER" />
             </intent-filter>
         </activity>
+        
         <service
             android:enabled="true"
             android:name=".sendSMS"

bin/classes/com/android/shellms/sendSMS.class

@@ -16,7 +16,7 @@
         android:layout_height="wrap_content"
         android:layout_alignParentBottom="true"
         android:layout_centerHorizontal="true"
-        android:text="Thanks for using. visit https://github.com/try2codesecure/ShellMS" />
+        android:text="Thanks for using. visit https://github.com/try2codesecure/ShellMS for Shell templates" />
 
     <TextView
         android:id="@+id/textView3"

res/layout/activity_main.xml

@@ -8,8 +8,11 @@
 
 package com.android.shellms;
 
+import java.util.ArrayList;
+
 import android.net.Uri;
 import android.os.Bundle;
+import android.app.PendingIntent;
 import android.app.Service;
 import android.telephony.PhoneNumberUtils;
 import android.telephony.SmsManager;
@@ -106,9 +109,9 @@ public int onStartCommand(Intent intent, int flags, int startId) {
 						sendsms(contact, msg, !SECRET);
 						Log.i(TAG, "Sent SMS to contact: " + contact );
 					} else	{
-						Log.e(TAG, "NO MESSAGE WILL BE SENT IN DEBUG MODE" );
-						Log.e(TAG, "Contact: " + contact );
-						Log.e(TAG, "Message: " + msg);
+						Log.d(TAG, "NO MESSAGE WILL BE SENT IN DEBUG MODE" );
+						Log.d(TAG, "Contact: " + contact );
+						Log.d(TAG, "Message: " + msg);
 					}
 				} else	{
 					Log.e(TAG, "Unknown Error occoured with contact: " + contact);
@@ -202,16 +205,34 @@ private String getNumberfromContact(String contact, Boolean debugging)	{
 	    }
 	}
 
-	
 	// This function sends the sms with the SMSManager
 	private void sendsms(String phoneNumber, String message, Boolean AddtoSent)	{
-		SmsManager sms = SmsManager.getDefault();
-        sms.sendTextMessage(phoneNumber, null, message, null, null);
-		if (AddtoSent)	{
-			addMessageToSent(phoneNumber, message);
-		}
-	}
-
+		String SENT = "SMS_SENT";
+        String DELIVERED = "SMS_DELIVERED";
+ 
+        ArrayList<PendingIntent> sentPendingIntents = new ArrayList<PendingIntent>();
+        ArrayList<PendingIntent> deliveredPendingIntents = new ArrayList<PendingIntent>();
+        
+        PendingIntent sentPI = PendingIntent.getBroadcast(this, 0, new Intent(SENT), 0);
+        PendingIntent deliveredPI = PendingIntent.getBroadcast(this, 0, new Intent(DELIVERED), 0);
+ 
+	    try {
+	    	SmsManager sms = SmsManager.getDefault();
+	        ArrayList<String> msgparts = sms.divideMessage(message);
+	        for (int i = 0; i < msgparts.size(); i++) {
+	            sentPendingIntents.add(i, sentPI);
+	            deliveredPendingIntents.add(i, deliveredPI);
+	        }
+	        sms.sendMultipartTextMessage(phoneNumber, null, msgparts, sentPendingIntents, deliveredPendingIntents);
+			if (AddtoSent)	{
+				addMessageToSent(phoneNumber, message);
+			}
+	    } catch (Exception e) {
+	        e.printStackTrace();
+	        Log.e(TAG, "undefined Error: SMS sending failed ... please REPORT to ISSUE Tracker");
+	    }
+    }		
+		
 	// This function add's the sent sms to the SMS sent folder
 	private void addMessageToSent(String phoneNumber, String message) {
         ContentValues sentSms = new ContentValues();
@@ -220,8 +241,8 @@ private void addMessageToSent(String phoneNumber, String message) {
 
         ContentResolver contentResolver = getContentResolver();
         contentResolver.insert(SENT_MSGS_CONTET_PROVIDER, sentSms);
-    }
-	
+	}
+
 	@Override
 	public IBinder onBind(Intent intent) {
 		// TODO Auto-generated method stub

src/com/android/shellms/sendSMS.java

@@ -0,0 +1,20 @@
+#!/bin/bash
+# ShellMS Script
+ADB=adb
+MYIFS=','
+#or your path to adb
+if [ $# != 2 ];then
+	echo "Usage: $0 \"Contact's DISPLAY NAME or Phone Number,nextContact,anotherContact,...\" \"Your message\""
+	exit
+else
+	IFS=$MYIFS read -ra CONTACTS <<< "$1"
+	for i in "${CONTACTS[@]}"; do
+		echo "... try sending to contact $i"
+		$ADB shell am startservice --user 0 -n com.android.shellms/.sendSMS -e contact "$i" -e msg "$2" 1>/dev/null
+	done
+
+	sleep 1;
+	$ADB logcat -d -s -C ShellMS_Service_sendSMS:*
+fi
+
+