@@ -68,37 +68,33 @@ Before you submit your Pull Request (PR) consider the following guidelines:
68
68
git checkout -b my-fix-branch master
69
69
```
70
70
71
- 4. Create your patch, ** including appropriate test cases ** .
71
+ 4. Create your patch.
72
72
73
73
5. Follow our [Coding Rules](# rules).
74
74
75
- 6. Run the full Linq2Acad test suite, as described in the [developer documentation][dev-doc], and ensure that all tests pass.
76
-
77
- 7. Commit your changes using a descriptive commit message that follows our [commit message conventions](# commit).
75
+ 6. Commit your changes using a descriptive commit message that follows our [commit message conventions](# commit).
78
76
Adherence to these conventions is necessary because release notes are automatically generated from these messages.
79
77
80
78
` ` ` shell
81
79
git commit --all
82
80
` ` `
83
81
Note: the optional commit ` -a` command line option will automatically " add" and " rm" edited files.
84
82
85
- 8 . Push your branch to GitHub:
83
+ 7 . Push your branch to GitHub:
86
84
87
85
` ` ` shell
88
86
git push origin my-fix-branch
89
87
` ` `
90
88
91
- 9 . In GitHub, send a pull request to ` Linq2Acad:master` .
89
+ 8 . In GitHub, send a pull request to ` Linq2Acad:master` .
92
90
93
91
# ### Addressing review feedback
94
92
95
93
If we ask for changes via code reviews then:
96
94
97
95
1. Make the required updates to the code.
98
96
99
- 2. Re-run the Angular test suites to ensure tests are still passing.
100
-
101
- 3. Create a fixup commit and push to your GitHub repository (this will update your Pull Request):
97
+ 2. Create a fixup commit and push to your GitHub repository (this will update your Pull Request):
102
98
103
99
` ` ` shell
104
100
git commit --all --fixup HEAD
@@ -170,7 +166,6 @@ After your pull request is merged, you can safely delete your branch and pull th
170
166
## <a name="rules"></a> Coding Rules
171
167
To ensure consistency throughout the source code, keep these rules in mind as you are working:
172
168
173
- * All features or bug fixes **must be tested** by one or more specs (unit-tests).
174
169
* All public API methods **must be documented**.
175
170
* Coding style and coding issues are checked using analyzers. All errors **and warnings** must be fixed.
176
171
0 commit comments