Skip to content

Commit df09c00

Browse files
committed
docs: Temporarily remove all rules that require testing
Rules that require testing will be removed unil the test runner is wokring again
1 parent 65d95aa commit df09c00

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

.github/CONTRIBUTING.md

+5-10
Original file line numberDiff line numberDiff line change
@@ -68,37 +68,33 @@ Before you submit your Pull Request (PR) consider the following guidelines:
6868
git checkout -b my-fix-branch master
6969
```
7070

71-
4. Create your patch, **including appropriate test cases**.
71+
4. Create your patch.
7272

7373
5. Follow our [Coding Rules](#rules).
7474

75-
6. Run the full Linq2Acad test suite, as described in the [developer documentation][dev-doc], and ensure that all tests pass.
76-
77-
7. Commit your changes using a descriptive commit message that follows our [commit message conventions](#commit).
75+
6. Commit your changes using a descriptive commit message that follows our [commit message conventions](#commit).
7876
Adherence to these conventions is necessary because release notes are automatically generated from these messages.
7977

8078
```shell
8179
git commit --all
8280
```
8381
Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files.
8482

85-
8. Push your branch to GitHub:
83+
7. Push your branch to GitHub:
8684

8785
```shell
8886
git push origin my-fix-branch
8987
```
9088

91-
9. In GitHub, send a pull request to `Linq2Acad:master`.
89+
8. In GitHub, send a pull request to `Linq2Acad:master`.
9290

9391
#### Addressing review feedback
9492

9593
If we ask for changes via code reviews then:
9694

9795
1. Make the required updates to the code.
9896

99-
2. Re-run the Angular test suites to ensure tests are still passing.
100-
101-
3. Create a fixup commit and push to your GitHub repository (this will update your Pull Request):
97+
2. Create a fixup commit and push to your GitHub repository (this will update your Pull Request):
10298

10399
```shell
104100
git commit --all --fixup HEAD
@@ -170,7 +166,6 @@ After your pull request is merged, you can safely delete your branch and pull th
170166
## <a name="rules"></a> Coding Rules
171167
To ensure consistency throughout the source code, keep these rules in mind as you are working:
172168
173-
* All features or bug fixes **must be tested** by one or more specs (unit-tests).
174169
* All public API methods **must be documented**.
175170
* Coding style and coding issues are checked using analyzers. All errors **and warnings** must be fixed.
176171

0 commit comments

Comments
 (0)