Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum configurable default tags to PrometheusReporter #92

Open
SokolAndrey opened this issue Feb 4, 2021 · 0 comments
Open

Add minimum configurable default tags to PrometheusReporter #92

SokolAndrey opened this issue Feb 4, 2021 · 0 comments

Comments

@SokolAndrey
Copy link
Collaborator

M3Reporter implementation of StatsReporter allows to set some default tags, which will be added to all reported metrics:

        StatsReporter reporter = new M3Reporter.Builder(new InetSocketAddress("localhost", 9052))
                                     .env("testing")
                                     .service("service_name")
                                     .includeHost(false)
                                     .commonTags(ImmutableMap.of("tag1", "42"))
                                     .build();

There is no such functionality in PrometheusReporter. We should add at minimum ability to set env, service and defaultTags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant