Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that no resources are required from external domains #581

Closed
1 of 3 tasks
Tracked by #779 ...
cbunicef opened this issue Sep 21, 2021 · 7 comments · Fixed by #592 or #940
Closed
1 of 3 tasks
Tracked by #779 ...

Ensure that no resources are required from external domains #581

cbunicef opened this issue Sep 21, 2021 · 7 comments · Fixed by #592 or #940
Assignees
Labels
Urgent Only very urgent bugs

Comments

@cbunicef
Copy link
Collaborator

cbunicef commented Sep 21, 2021

As a USER that doesn't have a data package, when I access IoGT for free through my MNO I don't want my experience to be disrupted when external resources don't load.

As a USER I want to be sure that I am not using up my data package if I've been told IoGT is free through my MNO.

Implications on external dependencies (as I understand them, please add)

Critical to address:

Important to address:

Unknown:

Urgent tag only applies to Critical items.

@sheralim012
Copy link
Contributor

for google analytics to honor facebook free basics we will have to deploy google tagging server ourself, here are the steps to deploy it manually. After that we have to configure our django app to use it which can be found here and here.

@geoo89 geoo89 reopened this Oct 3, 2021
@geoo89
Copy link
Contributor

geoo89 commented Oct 3, 2021

Reopening and removing the urgent tag to keep track of the less urgent items.

@cbunicef
Copy link
Collaborator Author

cbunicef commented Dec 15, 2021

There are still fonts being pulled from Google domains:

image

Adding urgent tag until that is sorted out.

Locally-served fonts is a must-have for Go Live.

@cbunicef cbunicef added the Urgent Only very urgent bugs label Dec 15, 2021
@cbunicef
Copy link
Collaborator Author

Re-opening issue to track Google Analytics server-side - this is actually important to get in the next major release.

@cbunicef
Copy link
Collaborator Author

cbunicef commented Mar 11, 2022

I was taking a look at #1186 and I just want to make sure that this PR works without Javascript and doesn't require calls from a user device to external servers. We need this for tracking to work on feature phones and Free Basics. For reference, the V1 GA solution doesn't have any GA-related code on the user-facing site from what I can see. Maybe this is an intermediary step?

However, good to note that we will need Javascript on the user-facing site in order to eventually accomplish #1196.

@ChrisMarsh82 maybe we can catch up on this during our Monday meeting

@istride
Copy link
Contributor

istride commented May 13, 2022

One of the problems with the server-side GTM container approach is that it still relies on javascript or iframe elements, both of which are not allowed under Free Basics.

In V1, analytics is implemented via a combination of django-google-analytics-app and some custom middleware (MoloGoogleAnalyticsMiddleware, IogtMoloGoogleAnalyticsMiddleware). I suggest we follow a similar approach.

@ChrisMarsh82 @sheralim012

@cbunicef
Copy link
Collaborator Author

This is long resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Urgent Only very urgent bugs
Projects
None yet
5 participants