-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that no resources are required from external domains #581
Comments
Reopening and removing the urgent tag to keep track of the less urgent items. |
Re-opening issue to track Google Analytics server-side - this is actually important to get in the next major release. |
I was taking a look at #1186 and I just want to make sure that this PR works without Javascript and doesn't require calls from a user device to external servers. We need this for tracking to work on feature phones and Free Basics. For reference, the V1 GA solution doesn't have any GA-related code on the user-facing site from what I can see. Maybe this is an intermediary step? However, good to note that we will need Javascript on the user-facing site in order to eventually accomplish #1196. @ChrisMarsh82 maybe we can catch up on this during our Monday meeting |
One of the problems with the server-side GTM container approach is that it still relies on javascript or iframe elements, both of which are not allowed under Free Basics. In V1, analytics is implemented via a combination of django-google-analytics-app and some custom middleware (MoloGoogleAnalyticsMiddleware, IogtMoloGoogleAnalyticsMiddleware). I suggest we follow a similar approach. |
This is long resolved |
As a USER that doesn't have a data package, when I access IoGT for free through my MNO I don't want my experience to be disrupted when external resources don't load.
As a USER I want to be sure that I am not using up my data package if I've been told IoGT is free through my MNO.
Implications on external dependencies (as I understand them, please add)
Critical to address:
Important to address:
Unknown:
Urgent tag only applies to Critical items.
The text was updated successfully, but these errors were encountered: