Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support chain upgrades in voyager #1511

Open
benluelo opened this issue Mar 7, 2024 · 3 comments
Open

Support chain upgrades in voyager #1511

benluelo opened this issue Mar 7, 2024 · 3 comments
Assignees
@benluelo
Labels
A-voyager Area: Our voyager relayer C-enhancement Category: An issue proposing an enhancement or a PR with one. P-low Low priority S-shelved Status: Not actively being worked on, PR/issue still open for reference

Comments

@benluelo
Copy link
Contributor

benluelo commented Mar 7, 2024

Voyager currently expects that chain ids never change, we either need to document this as expected behaviour or handle upgrades (specifically cosmos chains).
@benluelo benluelo added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Mar 7, 2024
@benluelo benluelo self-assigned this Mar 7, 2024
@aeryz
Copy link
Contributor

aeryz commented Mar 7, 2024

since voyager has no state, what would be the problem of the chain id being changed?

@benluelo
Copy link
Contributor Author

benluelo commented Mar 8, 2024

Existing messages will point to a non-existent chain after it has upgraded

@benluelo benluelo added S-shelved Status: Not actively being worked on, PR/issue still open for reference P-low Low priority A-voyager Area: Our voyager relayer labels Sep 21, 2024
@benluelo
Copy link
Contributor Author

shelving this for now as chains do not upgrade their chain id in practice. if we hit a case of this in the future, we can investigate possible solutions then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benluelo benluelo

Labels
A-voyager Area: Our voyager relayer C-enhancement Category: An issue proposing an enhancement or a PR with one. P-low Low priority S-shelved Status: Not actively being worked on, PR/issue still open for reference
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeryz @benluelo