Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll light client nit #2813

Open
aeryz opened this issue Aug 22, 2024 · 0 comments
Open

Scroll light client nit #2813

aeryz opened this issue Aug 22, 2024 · 0 comments
Assignees
@benluelo
Labels
A-lightclients Area: Light Clients E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-low Low priority

Comments

@aeryz
Copy link
Contributor

aeryz commented Aug 22, 2024

union/lib/unionlabs/src/ibc/lightclients/scroll/consensus_state.rs

Line 44 in 2ea524f

.map_err(TryFromConsensusStateError::IbcStorageRoot)?,

This needs to be StateRoot
@aeryz aeryz added A-lightclients Area: Light Clients E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-low Low priority labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benluelo benluelo

Labels
A-lightclients Area: Light Clients E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeryz @benluelo