Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure light clients #3245

Open
aeryz opened this issue Nov 11, 2024 · 3 comments
Open

Restructure light clients #3245

aeryz opened this issue Nov 11, 2024 · 3 comments

Comments

@aeryz
Copy link
Contributor

aeryz commented Nov 11, 2024

Thanks to the state lenses, we will have multiple implementations of the our light clients on different ecosystems. Before this, it made sense to have the light-clients directory. But now, it will be a mess very soon.

My suggestion is to split up everything based on its execution layer (evm, cosmwasm, move) such as:

evm/
    ibc/
    cometbls-light-client/

move/
    aptos/
        ibc/
    other-move/
        ibc/

cosmwasm/
    union-ibc/
        core/
        light-clients/
            ethereum/
            scroll/
            cometbls/
        lib/
            union-ibc-light-client/
        app/
            some-union-ibc-specific-app/
    ics08/
        light-clients/
            cometbls/
        lib/
            ics08-light-client
    some-common-contract/
@cor
Copy link
Contributor

cor commented Nov 11, 2024

Would move contain both aptos move and sui move? or are they so distinct that they deserve two top-level directories?

@benluelo
Copy link
Contributor

considering that they would be two separate ibc stack implementations, they would most likely be two directories

@aeryz
Copy link
Contributor Author

aeryz commented Nov 12, 2024

Would move contain both aptos move and sui move? or are they so distinct that they deserve two top-level directories?

Unfortunately yes. Aptos supports dynamic dispatch, but sui not. And their token and storage logic is considerably different. So yeah, SUI won't be a slightly different aptos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants