Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment lines 255 to 338 in uap.go #68

Open
cpunt opened this issue Jan 3, 2023 · 6 comments
Open

Uncomment lines 255 to 338 in uap.go #68

cpunt opened this issue Jan 3, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@cpunt
Copy link

cpunt commented Jan 3, 2023

Hey,

I currently use this library to gather telemetry from my unifi controller. I want to get aggregated wifi stats per radio but it appears that they have been commented out because they can be found in the VAP tables (uap.go lines 255 - 338). Is there anyway these can be uncommented since the aggregation of stats is useful? Also are the VAP tables the stats per radio and per ssid?

Thanks!

@davidnewhall
Copy link
Member

Did you test this requested change already?

@cpunt
Copy link
Author

cpunt commented Jan 4, 2023

So I have uncommented the code and tested this. I've run some tests and it appears Wifi0RxBytes + Wifi1RxBytes is equal to RxBytes in the Ap struct (which is expected and the breakdown I wanted). But when adding up the VapTables RxBytes for an Ap, the RxBytes does not equal the RxBytes in the Ap (Which I didn't expect). I'm trying to understand what data the VapTables actually contains. Do you know what the VapTables are?

@davidnewhall
Copy link
Member

Unfortunately the API is not documented and it's all guess work. I think VapTables is the wireless networks.

@cpunt
Copy link
Author

cpunt commented Jan 5, 2023

Thanks for the help. Can we uncomment uap.go lines 255 - 338? As this is what I need. I'm happy to make a pr or for you to commit

@davidnewhall
Copy link
Member

I seem to have left a comment that those data bits exist elsewhere. I don't have a problem with uncommenting that section, but we need to make sure unpoller doesn't automatically start throwing that new data into a time series database.

@cpunt
Copy link
Author

cpunt commented Jan 6, 2023

Okay, I'm keen to use this Unifi library for our project but haven't used the Unpoller library at all. How would we go about making sure this change doesn't automatically start throwing new data into the time series database? How does Unpoller select the data to insert?

@platinummonkey platinummonkey added the enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants