Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate updated template version #311

Open
realies opened this issue Mar 22, 2018 · 8 comments
Open

Indicate updated template version #311

realies opened this issue Mar 22, 2018 · 8 comments

Comments

@realies
Copy link
Contributor

realies commented Mar 22, 2018

Updating Docker containers might make them break if using an obsolete template. Perhaps indicate somewhere whenever a used template has a newer version?

@realies realies changed the title Indicate docker template updates Indicate updated template version Mar 22, 2018
@Squidly271
Copy link
Contributor

Squidly271 commented Mar 23, 2018

When dockerMan checks for updates, it also updates certain tags in the template if the author allows this. OTOH, description / overview, Support, Project, and Config entries (And depending upon the container/template, the update of the template can be troublesome at times)

@realies
Copy link
Contributor Author

realies commented Mar 23, 2018

Have lost a Postgres persistent data because the template was obsolete.

@limetech
Copy link
Contributor

Perhaps indicate somewhere whenever a used template has a newer version?

Please consider generating a PR to do this ;)

@realies
Copy link
Contributor Author

realies commented Mar 23, 2018

Should this be part of the webGui or the community applications plugin?

@Squidly271
Copy link
Contributor

Squidly271 commented Mar 24, 2018

Of the three Postgres containers available in CA, only the one in jj9987's repo supports updating of the template via dockerMan (It's the only one that has TemplateURL)

And, a PR for this is against dockerMan, not CA

@realies
Copy link
Contributor Author

realies commented Mar 24, 2018

This is the exact template in use. It seems the official Postgres image has changed storage locations, which has been reflected here juusujanar/unraid-templates@6d6c1f1 (line 57), although upon updating the container that did not change, causing the loss of data. The result was an empty data folder on the host directory due to permission issues with the enclosed files.

@Squidly271
Copy link
Contributor

Any PR that would have dockerMan automatically update the target against all config elements would be a very bad idea, as it's very common practice for users to substitute the targets the template maintainer dictates. A notification that the template has been updated though might also be problematic because templates change all the time, usually for minor things such as config description changes, required / not required, template description, etc.

How common is this issue?

@realies
Copy link
Contributor Author

realies commented Mar 28, 2018

Not aware how common, but losing all database data was not pleasant, hence looking for ways to prevent this from happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants