-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support other node images #49
Comments
+++, but here probably will be problems in rare situations when |
Will this image work as expected when there are native dependencies (need compilation)?
Aside from smaller size, how is it better than the official image? |
I'm wondering for a while now, can we just use the same image as Travis does? Is it publicly available for us to use and just use whatever they use? |
Yeah, I was thinking about it too. Would solve pretty much all user requests and issues. |
@vadimdemedes It looks like the images can be found here. This should be some docs, although not sure if we can do anything with it. Have to take a closer look. |
just drop the suffix btw, was just curious about docker and implemented it for the sake of training, of course dont have pretty UI const readFile = util.promisify(fs.readFile)
function getVersions () {
return readFile('./.travis.yml', 'utf8').then(
(str) => yaml.safeLoad(str).node_js
)
}
const opts = { stdio: 'inherit' }
const pass = (version) => () => console.log('Build', version, 'passed')
const fail = (version) => (er) =>
console.log('Build', version, 'failed', er.message)
const npmTest = (version) =>
execa('npm', ['test'], opts).then(pass(version), fail(version))
const npmInstall = (version) =>
execa('npm', ['install'], opts).then(() => npmTest(version))
const nodeInstall = (v) =>
execa('docker', ['pull', `node:${v}`], opts).then(() => npmInstall(v))
getVersions().then((versions) => pMap(versions, nodeInstall)).catch((er) => {
console.log('commit failed', er.stderr)
}) that's the whole CI core in reality :D from there on, only features can be added (like why not implement the hooks) and UI |
btw, when i tried The most slow step using Trevor is "building environment", don't know why. Takes 5+ minutes. |
I think |
I like
mhart/alpine-node
. It's extremely small image ~50mb. Would be better to have option to use this image.The text was updated successfully, but these errors were encountered: