Skip to content

Commit

Permalink
build: touch tools/doc/node_modules after run
Browse files Browse the repository at this point in the history
Currently, tools/doc/node_modules is not touched after running npm
install resulting in npm install being run every time. I missed this
while testing commit 88bff82 ("build:
make tools/doc/node_modules non-phony").

PR-URL: nodejs#22350
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
  • Loading branch information
danbev authored and BridgeAR committed Aug 20, 2018
1 parent 4e7d829 commit 104492b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1074,6 +1074,7 @@ lint-md-build: tools/remark-cli/node_modules \
tools/doc/node_modules: tools/doc/package.json
ifeq ($(node_use_openssl),true)
cd tools/doc && $(call available-node,$(run-npm-install))
@touch $@
else
@echo "Skipping tools/doc/node_modules (no crypto)"
endif
Expand Down

0 comments on commit 104492b

Please sign in to comment.