From f46a2dd91378b75fbf716fea62d1dc37afdf2439 Mon Sep 17 00:00:00 2001 From: Mark Nielsen Date: Wed, 28 Jun 2017 12:42:50 -0700 Subject: [PATCH] MDL-58948 behat: Fix spin method when callback throws exception Was preventing the sleep statements from running. This caused steps to fail too early when it was just waiting for something to change in the browser. --- lib/behat/behat_base.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/behat/behat_base.php b/lib/behat/behat_base.php index da8f69d10ca49..bb8a52b0e6c0d 100644 --- a/lib/behat/behat_base.php +++ b/lib/behat/behat_base.php @@ -335,8 +335,6 @@ protected function spin($lambda, $args = false, $timeout = false, $exception = f if (!$exception) { $exception = $e; } - // We wait until no exception is thrown or timeout expires. - continue; } if ($this->running_javascript()) {