From 1f894313182f6852ac333c211217afc705cc2ea4 Mon Sep 17 00:00:00 2001 From: Sam Blackshear Date: Tue, 8 Mar 2022 13:48:21 -0800 Subject: [PATCH] [chore] fastnft -> sui everywhere --- CONTRIBUTING.md | 2 +- README.md | 18 +++++++++--------- doc/src/learn/how-sui-works.md | 4 ++-- doc/src/move.md | 4 ++-- doc/src/objects.md | 2 +- sui_core/src/authority_aggregator.rs | 2 +- sui_core/src/client.rs | 18 +++++++++--------- sui_core/tests/README.md | 16 ++++++++-------- sui_programmability/adapter/src/adapter.rs | 2 +- .../adapter/src/unit_tests/adapter_tests.rs | 2 +- .../framework/sources/Event.move | 2 +- sui_programmability/framework/sources/GAS.move | 2 +- sui_programmability/framework/src/lib.rs | 2 +- .../framework/src/natives/event.rs | 2 +- .../framework/src/natives/test_scenario.rs | 2 +- .../framework/src/natives/tx_context.rs | 2 +- sui_types/src/base_types.rs | 4 ++-- sui_types/src/crypto.rs | 6 +++--- sui_types/src/messages.rs | 2 +- sui_types/src/move_package.rs | 4 ++-- 20 files changed, 49 insertions(+), 49 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 85caaa343323f..3f45503ae4b23 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -4,7 +4,7 @@ TODO: Define basic system requirements for a reliable environment: recommended O To contribute, ensure you have the latest version of the codebase. To clone the repository, run the following: ```bash -git clone https://github.com/mystenlabs/fastnft.git +git clone https://github.com/mystenlabs/sui.git cd sui cargo build --all --all-targets cargo test diff --git a/README.md b/README.md index 5f27920134018..84eff24f5344a 100644 --- a/README.md +++ b/README.md @@ -2,13 +2,13 @@ Welcome to Sui, a next generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the [Move](https://github.com/MystenLabs/awesome-move) programming language! Here are some suggested starting points: -* To jump right into building smart contract applications on top of Sui, go to [Move Quick Start](https://github.com/MystenLabs/fastnft/tree/main/doc/src/move.md). -* To experiment with a sample Sui wallet, check out [Wallet Quick Start](https://github.com/MystenLabs/fastnft/tree/main/doc/src/wallet.md). -* To go deep on how Sui works, read the Sui [white paper](https://github.com/MystenLabs/fastnft/tree/main/doc/paper/sui.pdf) and check out [Key Concepts](https://github.com/MystenLabs/fastnft/tree/main/doc/src/key-concepts.md). +* To jump right into building smart contract applications on top of Sui, go to [Move Quick Start](https://github.com/MystenLabs/sui/tree/main/doc/src/move.md). +* To experiment with a sample Sui wallet, check out [Wallet Quick Start](https://github.com/MystenLabs/sui/tree/main/doc/src/wallet.md). +* To go deep on how Sui works, read the Sui [white paper](https://github.com/MystenLabs/sui/tree/main/doc/paper/sui.pdf) and check out [Key Concepts](https://github.com/MystenLabs/sui/tree/main/doc/src/key-concepts.md). -* To understand what's possible by browsing Move code built on top of Sui, review the [examples](https://github.com/MystenLabs/fastnft/tree/main/sui_programmability/examples/sources) +* To understand what's possible by browsing Move code built on top of Sui, review the [examples](https://github.com/MystenLabs/sui/tree/main/sui_programmability/examples/sources) * To start coding against Sui's REST API's, start [here](https://app.swaggerhub.com/apis/MystenLabs/sui-api/0.1) -* To learn what distinguishes Sui from other blockchain systems, see [What Makes Sui Different?](https://github.com/MystenLabs/fastnft/tree/main/doc/src/what-makes-sui-different.md). +* To learn what distinguishes Sui from other blockchain systems, see [What Makes Sui Different?](https://github.com/MystenLabs/sui/tree/main/doc/src/what-makes-sui-different.md). @@ -16,9 +16,9 @@ Welcome to Sui, a next generation smart contract platform with high throughput, ## Architecture -Sui is a distributed ledger that stores a collection of programmable *[objects](https://github.com/MystenLabs/fastnft/tree/main/doc/src/objects.md)*, each with a globally unique ID. Every object is owned by a single *address*, and each address can own an arbitrary number of objects. +Sui is a distributed ledger that stores a collection of programmable *[objects](https://github.com/MystenLabs/sui/tree/main/doc/src/objects.md)*, each with a globally unique ID. Every object is owned by a single *address*, and each address can own an arbitrary number of objects. -The ledger is updated via a *[transaction](https://github.com/MystenLabs/fastnft/tree/main/doc/src/transactions.md)* sent by a particular address. A transaction can create, destroy, and write objects, as well as transfer them to other addresses. +The ledger is updated via a *[transaction](https://github.com/MystenLabs/sui/tree/main/doc/src/transactions.md)* sent by a particular address. A transaction can create, destroy, and write objects, as well as transfer them to other addresses. Structurally, a transaction contains a set of input object references and a pointer to a Move code object that already exists in the ledger. Executing a transaction produces updates to the input objects and (if applicable) a set of freshly created objects along with their owners. A transaction whose sender is address *A* can accept objects owned by *A*, shared objects, and objects owned by other objects in the first two groups as input. @@ -42,9 +42,9 @@ flowchart LR Sui authorities agree on and execute transactions in parallel with high throughput using [Byzantine Consistent Broadcast](https://en.wikipedia.org/wiki/Byzantine_fault). ## Move quick start -See the [Move Quick Start](https://github.com/MystenLabs/fastnft/tree/main/doc/src/move.md) for installation, defining custom objects, object operations (create/destroy/update/transfer/freeze), publishing, and invoking your published code. +See the [Move Quick Start](https://github.com/MystenLabs/sui/tree/main/doc/src/move.md) for installation, defining custom objects, object operations (create/destroy/update/transfer/freeze), publishing, and invoking your published code. ## Wallet quick start -See the [Wallet Quick Start](https://github.com/MystenLabs/fastnft/tree/main/doc/src/wallet.md) for installation, querying the chain, client setup, sending transfer transactions, and viewing the effects. +See the [Wallet Quick Start](https://github.com/MystenLabs/sui/tree/main/doc/src/wallet.md) for installation, querying the chain, client setup, sending transfer transactions, and viewing the effects. diff --git a/doc/src/learn/how-sui-works.md b/doc/src/learn/how-sui-works.md index 3396e74a28397..f03703be6ef89 100644 --- a/doc/src/learn/how-sui-works.md +++ b/doc/src/learn/how-sui-works.md @@ -2,9 +2,9 @@ title: How Sui Works --- -Sui is a distributed ledger that stores a collection of programmable *[objects](https://github.com/MystenLabs/fastnft/tree/main/doc/src/objects.md)*, each with a globally unique ID. Every object is owned by a single *address*, and each address can own an arbitrary number of objects. +Sui is a distributed ledger that stores a collection of programmable *[objects](https://github.com/MystenLabs/sui/tree/main/doc/src/objects.md)*, each with a globally unique ID. Every object is owned by a single *address*, and each address can own an arbitrary number of objects. -The ledger is updated via a *[transaction](https://github.com/MystenLabs/fastnft/tree/main/doc/src/transactions.md)* sent by a particular address. A transaction can create, destroy, and write objects, as well as transfer them to other addresses. +The ledger is updated via a *[transaction](https://github.com/MystenLabs/sui/tree/main/doc/src/transactions.md)* sent by a particular address. A transaction can create, destroy, and write objects, as well as transfer them to other addresses. Structurally, a transaction contains a set of input object references and a pointer to a Move code object that already exists in the ledger. Executing a transaction produces updates to the input objects and (if applicable) a set of freshly created objects along with their owners. A transaction whose sender is address *A* can accept objects owned by *A*, shared objects, and objects owned by other objects in the first two groups as input. diff --git a/doc/src/move.md b/doc/src/move.md index 9d96210175345..4f2e4fb6ed9b3 100644 --- a/doc/src/move.md +++ b/doc/src/move.md @@ -380,7 +380,7 @@ name = "MyMovePackage" version = "0.0.1" [dependencies] -Sui = { local = "../fastnft/sui_programmability/framework/" } +Sui = { local = "../sui/sui_programmability/framework/" } [addresses] MyMovePackage = "0x0" @@ -554,7 +554,7 @@ little to do with Sui beyond using some Sui packages, such as already very useful for developers writing Move code for Sui, they may also want to test additional Sui-specific features. In particular, a Move call in Sui is encapsulated in a Sui -[transaction](https://github.com/MystenLabs/fastnft/blob/main/doc/transactions.md), +[transaction](https://github.com/MystenLabs/sui/blob/main/doc/transactions.md), and a developer may wish to test interactions between different transactions within a single test (e.g. one transaction creating an object and the other one transferring it). diff --git a/doc/src/objects.md b/doc/src/objects.md index f0a568970a9e8..dcbd5a5fad054 100644 --- a/doc/src/objects.md +++ b/doc/src/objects.md @@ -30,7 +30,7 @@ Transactions (and thus, certificates) take objects as input, read/write/mutate t To construct this graph, we add a node for each committed transaction and draw a directed edge labeled with object reference `O` from transaction `A` to transaction `B` if `A` produced object `O` (i.e., created or mutated `O`) and transaction `B` takes object `O` as an input. EDITORIAL NOTE: A diagram would be useful here. Can we use Mermaid as now seen in the [Summary](SUMMARY.md) thanks to Evan? Tracked in: -https://github.com/MystenLabs/fastnft/issues/564 +https://github.com/MystenLabs/sui/issues/564 The root of this DAG is a *genesis* transaction that takes no inputs and produces the objects that exist in the initial state of the system. The DAG can be extended by identifying mutable transaction outputs that have not yet been consumed by any committed transaction and sending a new transaction that takes these outputs (and optionally, immutable transaction outputs) as inputs. diff --git a/sui_core/src/authority_aggregator.rs b/sui_core/src/authority_aggregator.rs index 64352f13c08d0..0567d5abdfefa 100644 --- a/sui_core/src/authority_aggregator.rs +++ b/sui_core/src/authority_aggregator.rs @@ -1119,7 +1119,7 @@ where // For now assume all authorities. Assume they're all honest // This assumption is woeful, and should be fixed - // TODO: https://github.com/MystenLabs/fastnft/issues/320 + // TODO: https://github.com/MystenLabs/sui/issues/320 let results = future::join_all(authority_clients.iter().map(|(_, ac)| { tokio::time::timeout(timeout, ac.handle_object_info_request(request.clone())) })) diff --git a/sui_core/src/client.rs b/sui_core/src/client.rs index da1cee6eb41a8..5219a208894cd 100644 --- a/sui_core/src/client.rs +++ b/sui_core/src/client.rs @@ -245,7 +245,7 @@ impl ClientState { /// It is recommended that one call sync and download_owned_objects /// right after constructor to fetch missing info form authorities /// TODO: client should manage multiple addresses instead of each addr having DBs - /// https://github.com/MystenLabs/fastnft/issues/332 + /// https://github.com/MystenLabs/sui/issues/332 #[cfg(test)] pub fn new(path: PathBuf, address: SuiAddress) -> Self { ClientState { @@ -413,7 +413,7 @@ impl ClientState { /// We use this to ensure that a transaction can indeed unlock or lock certain objects in the transaction /// This means either exactly all the objects are owned by this transaction, or by no transaction /// The caller has to explicitly find which objects are locked - /// TODO: always return true for immutable objects https://github.com/MystenLabs/fastnft/issues/305 + /// TODO: always return true for immutable objects https://github.com/MystenLabs/sui/issues/305 fn can_lock_or_unlock(&self, transaction: &Transaction) -> Result { let iter_matches = self.store.pending_transactions.multi_get( &transaction @@ -438,7 +438,7 @@ impl ClientState { /// One should call can_lock_or_unlock before locking as this overwites the previous lock /// If the object is already locked, ensure it is unlocked by calling unlock_pending_transaction_objects /// Client runs sequentially right now so access to this is safe - /// Double-locking can cause equivocation. TODO: https://github.com/MystenLabs/fastnft/issues/335 + /// Double-locking can cause equivocation. TODO: https://github.com/MystenLabs/sui/issues/335 pub fn lock_pending_transaction_objects( &self, transaction: &Transaction, @@ -506,7 +506,7 @@ where /// Update local object states using newly created certificate and ObjectInfoResponse from the Confirmation step. /// This functions locks all the input objects if possible, and unlocks at the end of confirmation or if an error occurs /// TODO: define other situations where we can unlock objects after authority error - /// https://github.com/MystenLabs/fastnft/issues/346 + /// https://github.com/MystenLabs/sui/issues/346 async fn execute_transaction( &mut self, transaction: Transaction, @@ -534,9 +534,9 @@ where // How do we handle errors on authority which lock objects? // Currently VM crash can keep objects locked, but we would like to avoid this. - // TODO: https://github.com/MystenLabs/fastnft/issues/349 - // https://github.com/MystenLabs/fastnft/issues/211 - // https://github.com/MystenLabs/fastnft/issues/346 + // TODO: https://github.com/MystenLabs/sui/issues/349 + // https://github.com/MystenLabs/sui/issues/211 + // https://github.com/MystenLabs/sui/issues/346 let account = self.get_or_create_account(transaction.sender_address())?; account.unlock_pending_transaction_objects(&transaction)?; @@ -586,7 +586,7 @@ where } // TODO: decide what to do with failed object downloads - // https://github.com/MystenLabs/fastnft/issues/331 + // https://github.com/MystenLabs/sui/issues/331 let _failed = self .download_objects_not_in_db(address, objs_to_download) .await?; @@ -638,7 +638,7 @@ where let unique_pending_transactions = account.get_unique_pending_transactions(); // Transactions are idempotent so no need to prevent multiple executions // Need some kind of timeout or max_trials here? - // TODO: https://github.com/MystenLabs/fastnft/issues/330 + // TODO: https://github.com/MystenLabs/sui/issues/330 for transaction in unique_pending_transactions { self.execute_transaction(transaction.clone()) .await diff --git a/sui_core/tests/README.md b/sui_core/tests/README.md index 7f8e01087b9c7..8d813a22b968b 100644 --- a/sui_core/tests/README.md +++ b/sui_core/tests/README.md @@ -15,10 +15,10 @@ https://github.com/novifinancial/serde-reflection In this example, we will update one of our core types (SuiError), and then update the manifest: ``` -huitseeker@Garillots-MBP.localdomain➜~/tmp/fastnft(main)» git checkout main [7:40:40] +huitseeker@Garillots-MBP.localdomain➜~/tmp/sui(main)» git checkout main [7:40:40] Already on 'main' Your branch is up to date with 'origin/main'. -huitseeker@Garillots-MBP.localdomain➜~/tmp/fastnft(main)» ruplacer --subvert 'CertificateAuthorityReuse' 'CertificateAuthorityDuplicate' --go [8:42:33] +huitseeker@Garillots-MBP.localdomain➜~/tmp/sui(main)» ruplacer --subvert 'CertificateAuthorityReuse' 'CertificateAuthorityDuplicate' --go [8:42:33] ./sui_types/src/error.rs:103 - CertificateAuthorityReuse, ./sui_types/src/error.rs:103 + CertificateAuthorityDuplicate, @@ -36,22 +36,22 @@ Performed 4 replacements on 196 matching files Now our code is modified in a way that will make the format test fail: let's update the manifest. ``` -huitseeker@Garillots-MBP.localdomain➜~/tmp/fastnft(main✗)» cd sui_core [8:43:38] -huitseeker@Garillots-MBP.localdomain➜tmp/fastnft/sui_core(main✗)» cargo -q run --example generate-format -- print > tests/staged/sui.yaml +huitseeker@Garillots-MBP.localdomain➜~/tmp/sui(main✗)» cd sui_core [8:43:38] +huitseeker@Garillots-MBP.localdomain➜tmp/sui/sui_core(main✗)» cargo -q run --example generate-format -- print > tests/staged/sui.yaml ``` Let's check that we pass the test again: ``` -huitseeker@Garillots-MBP.localdomain➜tmp/fastnft/sui_core(main✗)» cargo test format 2>&1 |tail -n 40 [8:47:22] +huitseeker@Garillots-MBP.localdomain➜tmp/sui/sui_core(main✗)» cargo test format 2>&1 |tail -n 40 [8:47:22] Finished test [unoptimized + debuginfo] target(s) in 0.35s - Running unittests (/Users/huitseeker/tmp/fastnft/target/debug/deps/sui_core-5796871991341984) + Running unittests (/Users/huitseeker/tmp/sui/target/debug/deps/sui_core-5796871991341984) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 52 filtered out; finished in 0.00s - Running tests/format.rs (/Users/huitseeker/tmp/fastnft/target/debug/deps/format-ecdfa91a67810be3) + Running tests/format.rs (/Users/huitseeker/tmp/sui/target/debug/deps/format-ecdfa91a67810be3) running 1 test Finished dev [unoptimized + debuginfo] target(s) in 0.20s @@ -59,7 +59,7 @@ running 1 test test test_format ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.48s -huitseeker@Garillots-MBP.localdomain➜tmp/fastnft/sui_core(main✗)» git status -s [8:47:38] +huitseeker@Garillots-MBP.localdomain➜tmp/sui/sui_core(main✗)» git status -s [8:47:38] M tests/staged/sui.yaml M ../sui_types/src/error.rs M ../sui_types/src/messages.rs diff --git a/sui_programmability/adapter/src/adapter.rs b/sui_programmability/adapter/src/adapter.rs index bb5e746632848..b019148ca6e74 100644 --- a/sui_programmability/adapter/src/adapter.rs +++ b/sui_programmability/adapter/src/adapter.rs @@ -428,7 +428,7 @@ pub fn verify_and_link< let mut gas_status = get_gas_status(cost_table, None) .expect("Can only fail if gas budget is too high, and we didn't supply one"); let mut session = vm.new_session(state_view); - // TODO(https://github.com/MystenLabs/fastnft/issues/69): avoid this redundant serialization by exposing VM API that allows us to run the linker directly on `Vec` + // TODO(https://github.com/MystenLabs/sui/issues/69): avoid this redundant serialization by exposing VM API that allows us to run the linker directly on `Vec` let new_module_bytes = modules .iter() .map(|m| { diff --git a/sui_programmability/adapter/src/unit_tests/adapter_tests.rs b/sui_programmability/adapter/src/unit_tests/adapter_tests.rs index b75393874247d..7727d28bfc060 100644 --- a/sui_programmability/adapter/src/unit_tests/adapter_tests.rs +++ b/sui_programmability/adapter/src/unit_tests/adapter_tests.rs @@ -706,7 +706,7 @@ fn test_move_call_args_type_mismatch() { .contains("Expected 3 arguments calling function 'create', but found 2")); /* - // Need to fix https://github.com/MystenLabs/fastnft/issues/211 + // Need to fix https://github.com/MystenLabs/sui/issues/211 // in order to enable the following test. let pure_args = vec![ 10u64.to_le_bytes().to_vec(), diff --git a/sui_programmability/framework/sources/Event.move b/sui_programmability/framework/sources/Event.move index a7542a6550bd9..195d4cc216107 100644 --- a/sui_programmability/framework/sources/Event.move +++ b/sui_programmability/framework/sources/Event.move @@ -1,7 +1,7 @@ module Sui::Event { /// Add `t` to the event log of this transaction - // TODO(https://github.com/MystenLabs/fastnft/issues/19): + // TODO(https://github.com/MystenLabs/sui/issues/19): // restrict to internal types once we can express this in the ability system public native fun emit(event: T); } \ No newline at end of file diff --git a/sui_programmability/framework/sources/GAS.move b/sui_programmability/framework/sources/GAS.move index bc2f351e6d7e3..3dc71c38658bf 100644 --- a/sui_programmability/framework/sources/GAS.move +++ b/sui_programmability/framework/sources/GAS.move @@ -10,7 +10,7 @@ module Sui::GAS { /// Register the token to acquire its `TreasuryCap`. Because /// this is a module initializer, it ensures the currency only gets /// registered once. - // TODO(https://github.com/MystenLabs/fastnft/issues/90): implement module initializers + // TODO(https://github.com/MystenLabs/sui/issues/90): implement module initializers fun init(ctx: &mut TxContext) { // Get a treasury cap for the coin and give it to the transaction sender let treasury_cap = Coin::create_currency(GAS{}, ctx); diff --git a/sui_programmability/framework/src/lib.rs b/sui_programmability/framework/src/lib.rs index c64de69e87a11..754718965f41f 100644 --- a/sui_programmability/framework/src/lib.rs +++ b/sui_programmability/framework/src/lib.rs @@ -162,7 +162,7 @@ fn verify_modules(modules: &[CompiledModule]) -> SuiResult { sui_bytecode_verifier::verify_module(m)?; } Ok(()) - // TODO(https://github.com/MystenLabs/fastnft/issues/69): Run Move linker + // TODO(https://github.com/MystenLabs/sui/issues/69): Run Move linker } fn build_framework(framework_dir: &Path) -> SuiResult> { diff --git a/sui_programmability/framework/src/natives/event.rs b/sui_programmability/framework/src/natives/event.rs index f5e56ba569633..bf41def9cdeb6 100644 --- a/sui_programmability/framework/src/natives/event.rs +++ b/sui_programmability/framework/src/natives/event.rs @@ -33,7 +33,7 @@ pub fn emit( match ty { Type::Struct(..) | Type::StructInstantiation(..) => (), ty => { - // TODO: // TODO(https://github.com/MystenLabs/fastnft/issues/19): enforce this in the ability system + // TODO: // TODO(https://github.com/MystenLabs/sui/issues/19): enforce this in the ability system panic!("Unsupported event type {:?}--struct expected", ty) } } diff --git a/sui_programmability/framework/src/natives/test_scenario.rs b/sui_programmability/framework/src/natives/test_scenario.rs index ebb952bd79f02..6cd4f30bda5eb 100644 --- a/sui_programmability/framework/src/natives/test_scenario.rs +++ b/sui_programmability/framework/src/natives/test_scenario.rs @@ -136,7 +136,7 @@ fn get_inventory_for( .filter_map(|(_, obj)| { // TODO: We should also be able to include objects indirectly owned by the // requested address through owning other objects. - // https://github.com/MystenLabs/fastnft/issues/673 + // https://github.com/MystenLabs/sui/issues/673 if (obj.owner == Owner::AddressOwner(sui_addr) || obj.owner.is_shared()) && &obj.type_ == type_ { diff --git a/sui_programmability/framework/src/natives/tx_context.rs b/sui_programmability/framework/src/natives/tx_context.rs index 80050988d2288..bfae0c4545d29 100644 --- a/sui_programmability/framework/src/natives/tx_context.rs +++ b/sui_programmability/framework/src/natives/tx_context.rs @@ -26,7 +26,7 @@ pub fn fresh_id( let ids_created = pop_arg!(args, u64); let tx_hash = pop_arg!(args, Vec); - // TODO(https://github.com/MystenLabs/fastnft/issues/58): finalize digest format + // TODO(https://github.com/MystenLabs/sui/issues/58): finalize digest format // unwrap safe because all digests in Move are serialized from the Rust `TransactionDigest` let digest = TransactionDigest::try_from(tx_hash.as_slice()).unwrap(); let id = Value::address(AccountAddress::from(digest.derive_id(ids_created))); diff --git a/sui_types/src/base_types.rs b/sui_types/src/base_types.rs index 039546005ff4e..481d2be3bf361 100644 --- a/sui_types/src/base_types.rs +++ b/sui_types/src/base_types.rs @@ -206,7 +206,7 @@ impl TransactionDigest { /// A digest we use to signify the parent transaction was the genesis, /// ie. for an object there is no parent digest. /// - /// TODO(https://github.com/MystenLabs/fastnft/issues/65): we can pick anything here + /// TODO(https://github.com/MystenLabs/sui/issues/65): we can pick anything here pub fn genesis() -> Self { Self::new([0; 32]) } @@ -214,7 +214,7 @@ impl TransactionDigest { /// Create an ObjectID from `self` and `creation_num`. /// Caller is responsible for ensuring that `creation_num` is fresh pub fn derive_id(&self, creation_num: u64) -> ObjectID { - // TODO(https://github.com/MystenLabs/fastnft/issues/58):audit ID derivation + // TODO(https://github.com/MystenLabs/sui/issues/58):audit ID derivation let mut hasher = Sha3_256::default(); hasher.update(self.0); diff --git a/sui_types/src/crypto.rs b/sui_types/src/crypto.rs index c3a685e0f8480..29adc84cf2198 100644 --- a/sui_types/src/crypto.rs +++ b/sui_types/src/crypto.rs @@ -106,13 +106,13 @@ impl TryInto for PublicKeyBytes { type Error = SuiError; fn try_into(self) -> Result { - // TODO(https://github.com/MystenLabs/fastnft/issues/101): Do better key validation + // TODO(https://github.com/MystenLabs/sui/issues/101): Do better key validation // to ensure the bytes represent a point on the curve. PublicKey::from_bytes(self.as_ref()).map_err(|_| SuiError::InvalidAuthenticator) } } -// TODO(https://github.com/MystenLabs/fastnft/issues/101): more robust key validation +// TODO(https://github.com/MystenLabs/sui/issues/101): more robust key validation impl TryFrom<&[u8]> for PublicKeyBytes { type Error = SuiError; @@ -220,7 +220,7 @@ impl Signature { } // is this a cryptographically correct public key? - // TODO: perform stricter key validation, sp. small order points, see https://github.com/MystenLabs/fastnft/issues/101 + // TODO: perform stricter key validation, sp. small order points, see https://github.com/MystenLabs/sui/issues/101 let public_key = ed25519_dalek::PublicKey::from_bytes(self.public_key_bytes()).map_err(|err| { SuiError::InvalidSignature { diff --git a/sui_types/src/messages.rs b/sui_types/src/messages.rs index b6a3b5a0452c9..47d273c634c32 100644 --- a/sui_types/src/messages.rs +++ b/sui_types/src/messages.rs @@ -174,7 +174,7 @@ pub struct CertifiedTransaction { // maintain the invariant that valid certificates with distinct signatures are equivalent, but yet-unchecked // certificates that differ on signers aren't. // -// see also https://github.com/MystenLabs/fastnft/issues/266 +// see also https://github.com/MystenLabs/sui/issues/266 // static_assertions::assert_not_impl_any!(CertifiedTransaction: Hash, Eq, PartialEq); diff --git a/sui_types/src/move_package.rs b/sui_types/src/move_package.rs index 7d89f1062ed08..8cda22fe00301 100644 --- a/sui_types/src/move_package.rs +++ b/sui_types/src/move_package.rs @@ -54,7 +54,7 @@ impl MovePackage { pub fn id(&self) -> ObjectID { // TODO: simplify this - // https://github.com/MystenLabs/fastnft/issues/249 + // https://github.com/MystenLabs/sui/issues/249 // All modules in the same package must have the same address. Pick any ObjectID::from( *CompiledModule::deserialize(self.module_map.values().next().unwrap()) @@ -87,7 +87,7 @@ impl MovePackage { module_name: module.to_string(), })?; let m = CompiledModule::deserialize(bytes) - .expect("Unwrap safe because FastX serializes/verifies modules before publishing them"); + .expect("Unwrap safe because Sui serializes/verifies modules before publishing them"); Function::new_from_name(&m, function).ok_or(SuiError::FunctionNotFound { error: format!(