Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skyline visualization bugs #1288

Open
Apirog9 opened this issue Dec 2, 2024 · 3 comments
Open

Skyline visualization bugs #1288

Apirog9 opened this issue Dec 2, 2024 · 3 comments

Comments

@Apirog9
Copy link

Apirog9 commented Dec 2, 2024

Hello, I have found several problems with skyline visualization of results:

  • if .dia files are used, it attempts to load them into skyline. Replacing them by .mzml in raw data window fixes problem. wold be good to loog for .mzml files in data directory.
  • in skyline settings , mass accuracies for MS1 and MS2 seem to be reversed.

Artur

@vdemichev
Copy link
Owner

Hi Artur,

  • Yes, it does not work with .dia, need to use the original raw files. This unfortunately will not be fixed in the future as Skyline just does not support those.

  • These are fixed, i.e. since Skyline will not apply same mass correction as DIA-NN, it makes sense to use fairly wide generic mass tolerances.

Best,
Vadim

@Apirog9
Copy link
Author

Apirog9 commented Dec 2, 2024

Hi, what I actually saw was settings in DIANN to 5ppm MS1 mass accuracy and 30ppm MS2 mass accuracy. In skyline I've got 30ppm for MS1 and 5ppm for MS2, which obviously messed up chromatogram extraction.

@vdemichev
Copy link
Owner

Oh, my error, correct. Thank you spotting this!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants