Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UIView animation instead of pop? #14

Open
JonasGessner opened this issue Sep 21, 2014 · 2 comments
Open

Use UIView animation instead of pop? #14

JonasGessner opened this issue Sep 21, 2014 · 2 comments

Comments

@JonasGessner
Copy link
Contributor

The POPSpringAnimation can be replaced by [UIView animateWithDuration:delay:usingSpringWithDamping:initialSpringVelocity:options: animations:completion:], which allows you to create spring animations that are very similar to those of a POPSpringAnimations. The advantage of this though is that 1. there is no need for a big 3rd party library (pop), and 2. It isn't tied to CALayers but you can also animate a UIView this way. The fact that the button would no longer rely on pop is a big deal. Pop is a massive library compared to this tiny button library. I really hope that you consider removing pop in favor of the UIKit spring animation. I would be glad to help updating the code!

@victorBaro
Copy link
Owner

Hello @JonasGessner
First of all thank you very much for your comment.

I will think about it as soon as I have some spare time. The reason of using Pop SpringAnimation was the fact that Pop automatically 'recalculates' the animation based on current status with no extra work.

I think the best thing I will do is fork my own project using UIViews as you suggest.

Thanks again for your comment!

@JonasGessner
Copy link
Contributor Author

UIView can do the same if you pass UIViewAnimationOptionBeginFromCurrentState as animation option. So there's really no reason to use pop ;) I've also found pop to lag sometimes while UIView animations are better performance wise and seem to lag less! Thanks for considering to remove pop, it would be really awesome! If you need help let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants