Skip to content

Commit

Permalink
video: ssd1307fb: Use gpiod_set_value_cansleep() for reset
Browse files Browse the repository at this point in the history
The reset signal can be produced by GPIO expander that can sleep.
In that case the probe function fails. Allow using GPIO expanders for
the reset signal by using the non-atomic gpiod_set_value_cansleep()
function.

Signed-off-by: Michal Vokáč <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Rob Herring <[email protected]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
  • Loading branch information
zandar authored and bzolnier committed Oct 8, 2018
1 parent aae3394 commit 7d1b8d7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/video/fbdev/ssd1307fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -667,9 +667,9 @@ static int ssd1307fb_probe(struct i2c_client *client,

if (par->reset) {
/* Reset the screen */
gpiod_set_value(par->reset, 0);
gpiod_set_value_cansleep(par->reset, 0);
udelay(4);
gpiod_set_value(par->reset, 1);
gpiod_set_value_cansleep(par->reset, 1);
udelay(4);
}

Expand Down

0 comments on commit 7d1b8d7

Please sign in to comment.