Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issues with delay blocking #25

Open
vinceau opened this issue Jan 31, 2020 · 0 comments
Open

Potential issues with delay blocking #25

vinceau opened this issue Jan 31, 2020 · 0 comments

Comments

@vinceau
Copy link
Owner

vinceau commented Jan 31, 2020

Currently delays will block the list of actions. e.g. 20 second delay before clipping, and then a 10 second delay before OBS scene changing, will cause the OBS scene change to happen roughly 30 seconds after the initial event was detected.

This might not be the preferred behaviour. You can get around this for now by ordering the actions such that the action with the shortest delay happens first, and subsequent actions would set the delay to be the cumulative delay based on previous actions. e.g. set the 10 second delay for OBS scene changing first, then after that make the Twitch clip action have a 10 second delay, which would have been around 20 seconds cumulative.

Ideally it would be possible to specify whether delaying actions should block the other actions from proceeding. If it is set to not block, we could use setTimeout to trigger the action. This however would cause issues with context sharing. For example, if you expect to have access to the {{ clipID }} context variable, but the Twitch clip is set to not block, the clip ID would not be available when the action is executed.

@vinceau vinceau added bug Something isn't working help wanted Extra attention is needed labels Mar 26, 2020
@vinceau vinceau removed the bug Something isn't working label May 18, 2020
@vinceau vinceau removed the help wanted Extra attention is needed label Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant