Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

Update to latest Envoy? #6

Open
rohrit opened this issue Jul 6, 2020 · 4 comments
Open

Update to latest Envoy? #6

rohrit opened this issue Jul 6, 2020 · 4 comments

Comments

@rohrit
Copy link

rohrit commented Jul 6, 2020

Are there any plans to update this to the latest version of Envoy?

@hans00
Copy link

hans00 commented Jul 6, 2020

I forked this project and upgraded to latest version.
And also modify some TODO code.

You can try it.

https://github.com/hans00/ModSecurity-envoy

@moderation
Copy link

The company behind this repo Octarine Security was acquired by VMWare - https://techcrunch.com/2020/05/13/vmware-to-acquire-kubernetes-security-startup-octarine-and-fold-it-into-carbon-black/. It would be nice to get an update from VMWare as to whether they plan to maintain this repo but from the commit history you should assume they wont.

@rohrit
Copy link
Author

rohrit commented Jul 7, 2020

@hans00 , thank you for providing the link.

@hayoade1
Copy link

@hans00 thanks for sharing the link. I tried it and get the clang failed error described below. Could you please suggest a resolution? Thanks

Build failure details:

ERROR: ModSecurity-envoy/http-filter-modsecurity/BUILD:21:17: C++ compilation of rule '//http-filter-modsecurity:webhook_fetch_lib' failed (Exit 1): clang failed: error executing command clang+llvm-10.0.0-x86_64-linux-gnu-ubuntu-18.04/bin/clang -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++0x' -MD ... (remaining 1385 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox clang failed: error executing command clang+llvm-10.0.0-x86_64-linux-gnu-ubuntu-18.04/bin/clang -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++0x' -MD ... (remaining 1385 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
http-filter-modsecurity/webhook_fetcher.cc:25:12: error: no member named 'get' in 'Envoy::Upstream::ClusterManager'
if (!cm_.get(uri_.cluster())) {
~~~ ^
http-filter-modsecurity/webhook_fetcher.cc:34:19: error: no viable overloaded '='
message->body() = std::make_uniqueBuffer::OwnedImpl(body);

bazel-out/k8-fastbuild/bin/external/envoy/include/envoy/buffer/_virtual_includes/buffer_interface/envoy/buffer/buffer.h:78:7: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from 'typename _MakeUniq<OwnedImpl>::__single_object' (aka 'unique_ptr<Envoy::Buffer::OwnedImpl>') to 'const Envoy::Buffer::Instance' for 1st argument
class Instance {
    ^
http-filter-modsecurity/webhook_fetcher.cc:43:7: error: no member named 'httpAsyncClientForCluster' in 'Envoy::Upstream::ClusterManager'
cm_.httpAsyncClientForCluster(uri_.cluster())
~~~ ^


Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants