sync camera improvements (duckduckgo#1785)

Task/Issue URL: https://app.asana.com/0/1201493110486074/1204739930808628/f
Tech Design URL:
CC:

Description:

Doesn't stop the camera when a code is scanned. Also adds some feedback if the code is not accepted.

Author: brindy

LocalPackages/SyncUI/Sources/SyncUI/Views/Internal/QRCodeScannerView.swift

@@ -24,11 +24,13 @@ struct QRCodeScannerView: UIViewRepresentable {
 
     let scanningQueue: ScanningQueue
 
-    var onCameraUnavailable: () -> Void
+    let onCameraUnavailable: () -> Void
+    let onInvalidCodeScanned: () -> Void
 
-    init(onQRCodeScanned: @escaping (String) async -> Bool, onCameraUnavailable: @escaping () -> Void) {
+    init(onQRCodeScanned: @escaping (String) async -> Bool, onCameraUnavailable: @escaping () -> Void, onInvalidCodeScanned: @escaping () -> Void) {
         scanningQueue = ScanningQueue(onQRCodeScanned)
         self.onCameraUnavailable = onCameraUnavailable
+        self.onInvalidCodeScanned = onInvalidCodeScanned
     }
 
     func makeCoordinator() -> Coordinator {
@@ -107,10 +109,10 @@ struct QRCodeScannerView: UIViewRepresentable {
                   let code = codeObject.stringValue else { return }
 
             captureCodes = false
-            Task {
-                if await cameraView.scanningQueue.codeScanned(code) {
-                    stop()
-                } else {
+            Task { @MainActor in
+                let codeAccepted = await cameraView.scanningQueue.codeScanned(code)
+                if !codeAccepted {
+                    cameraView.onInvalidCodeScanned()
                     captureCodes = true
                 }
             }

LocalPackages/SyncUI/Sources/SyncUI/Views/ScanOrPasteCodeView.swift

@@ -28,6 +28,8 @@ public struct ScanOrPasteCodeView: View {
         self.model = model
     }
 
+    @State var isInvalidCode = false
+
     @ViewBuilder
     func fullscreenCameraBackground() -> some View {
         Group {
@@ -36,6 +38,14 @@ public struct ScanOrPasteCodeView: View {
                     return await model.codeScanned($0)
                 } onCameraUnavailable: {
                     model.cameraUnavailable()
+                } onInvalidCodeScanned: {
+                    withAnimation(.linear.delay(0.0)) {
+                        isInvalidCode = true
+                    }
+
+                    withAnimation(.linear.delay(0.2)) {
+                        isInvalidCode = false
+                    }
                 }
             } else {
                 Rectangle()
@@ -162,7 +172,7 @@ public struct ScanOrPasteCodeView: View {
                 ForEach([0.0, 90.0, 180.0, 270.0], id: \.self) { degrees in
                     RoundedCorner()
                         .stroke(lineWidth: 8)
-                        .foregroundColor(.white.opacity(0.8))
+                        .foregroundColor(isInvalidCode ? .red.opacity(0.6) : .white.opacity(0.8))
                         .rotationEffect(.degrees(degrees), anchor: .center)
                         .frame(width: 300, height: 300)
                 }