Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Template not working #2078

Closed
egekorkan opened this issue Feb 12, 2025 · 2 comments · Fixed by #2079
Closed

PR Template not working #2078

egekorkan opened this issue Feb 12, 2025 · 2 comments · Fixed by #2079
Labels
Tooling topics around tooling for the specification

Comments

@egekorkan
Copy link
Contributor

The PR template showed up in my vs code environment but not in the GitHub Web UI. We do have it at https://github.com/w3c/wot-thing-description/blob/main/.github/PULL_REQUEST_TEMPLATE/basic.md . Anyone has an idea why it is not working?

@github-actions github-actions bot added the needs-triage Automatically added to new issues. TF should triage them with proper labels label Feb 12, 2025
@egekorkan egekorkan added Tooling topics around tooling for the specification and removed needs-triage Automatically added to new issues. TF should triage them with proper labels labels Feb 12, 2025
@egekorkan
Copy link
Contributor Author

It seems a query parameter needs to be present but the Web UI does not do it. Here is an example https://github.com/w3c/wot-thing-description/compare/main...egekorkan-patch-2?quick_pull=1&template=basic.md

@egekorkan
Copy link
Contributor Author

After digging up this issue a bit, we are not the only ones suffering from this... There are two stack overflow threads without a real solution:

VS Code Plugin actually looks for the different alternatives (see https://github.com/microsoft/vscode-pull-request-github/pull/1283/files) but GitHub itself does not. I will make a PR to move the template one level up, meaning that we will have that as the default. Since we have only one anyways, it should not matter. If there are more in the future, we can turn the default template to have two links inside, which will append a query parameter to the URL at the top. Nice that they advertise the feature themselves but without an integration to their main UI since 5+ years...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling topics around tooling for the specification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant