Only wait until element appears & fractional waits

Author: wadjei

src/Context/BrowserContext.php

@@ -6,11 +6,14 @@
 use Behat\Mink\Exception\ExpectationException;
 use Behat\Mink\Exception\ResponseTextException;
 use Behat\Mink\Exception\ElementNotFoundException;
+use WebDriver\Exception\StaleElementReference;
+use Behat\Behat\Tester\Exception\PendingException;
 
 class BrowserContext extends BaseContext
 {
     private $timeout;
     private $dateFormat = 'dmYHi';
+    private $timerStartedAt;
 
     public function __construct($timeout = 1)
     {
@@ -25,6 +28,16 @@ public function closeBrowser()
         $this->getSession()->stop();
     }
 
+    /**
+     * @BeforeScenario
+     *
+     * @When (I )start timing now
+     */
+    public function startTimer()
+    {
+        $this->timerStartedAt = time();
+    }
+
     /**
      * Set login / password for next HTTP authentication
      *
@@ -164,21 +177,35 @@ public function iWaitUntilISee($text)
      */
     public function iWaitSecondsUntilISeeInTheElement($count, $text, $element)
     {
+        $startTime = time();
         $this->iWaitSecondsForElement($count, $element);
 
         $expected = str_replace('\\"', '"', $text);
-        $node = $this->getSession()->getPage()->find('css', $element);
         $message = "The text '$expected' was not found after a $count seconds timeout";
 
-        $this->assertContains($expected, $node->getText(), $message);
+        $found = false;
+        do {
+            try {
+                usleep(1000);
+                $node = $this->getSession()->getPage()->find('css', $element);
+                $this->assertContains($expected, $node->getText(), $message);
+                return;
+            }
+            catch (ExpectationException $e) {
+                /* Intentionaly leave blank */
+            }
+            catch (StaleElementReference $e) {
+                // assume page reloaded whilst we were still waiting
+            }
+        } while (!$found && (time() - $startTime < $count));
     }
 
     /**
      * @Then (I )wait :count second(s)
      */
     public function iWaitSeconds($count)
     {
-        sleep($count);
+        usleep($count * 1000000);
     }
 
     /**
@@ -213,6 +240,7 @@ public function iWaitSecondsForElement($count, $element)
 
         do {
             try {
+                usleep(1000);
                 $node = $this->getSession()->getPage()->findAll('css', $element);
                 $this->assertCount(1, $node);
                 $found = true;
@@ -221,7 +249,7 @@ public function iWaitSecondsForElement($count, $element)
                 /* Intentionnaly leave blank */
             }
         }
-        while (time() - $startTime < $count);
+        while (!$found && (time() - $startTime < $count));
 
         if ($found === false) {
             $message = "The element '$element' was not found after a $count seconds timeout";
@@ -376,4 +404,32 @@ public function switchToMainFrame()
     {
         $this->getSession()->switchToIFrame();
     }
+
+    /**
+     * test time from when the scenario started
+     *
+     * @Then (the )total elapsed time should be :comparison than :expected seconds
+     * @Then (the )total elapsed time should be :comparison to :expected seconds
+     */
+    public function elapsedTime($comparison, $expected)
+    {
+        $elapsed = time() - $this->timerStartedAt;
+
+        switch ($comparison) {
+            case 'less':
+                $this->assertTrue($elapsed < $expected, "Elapsed time '$elapsed' is not less than '$expected' seconds.");
+                break;
+
+            case 'more':
+                $this->assertTrue($elapsed > $expected, "Elapsed time '$elapsed' is not more than '$expected' seconds.");
+                break;
+
+            case 'equal':
+                $this->assertTrue($elapsed === $expected, "Elapsed time '$elapsed' is not '$expected' seconds.");
+                break;
+
+            default:
+                throw new PendingException("Unknown comparison '$comparison'. Use 'less', 'more' or 'equal'");
+        }
+    }
 }

tests/features/browser.feature

@@ -62,10 +62,11 @@ Feature: Browser Feature
     @javascript
     Scenario: Wait before seeing
         Given I am on "/browser/timeout.html"
-        Then I wait 3 seconds until I see "timeout"
+        When I wait 3 seconds until I see "timeout"
         And I wait 1 second
         And I wait for "#iframe" element
         And I wait 5 seconds for "#iframe" element
+        Then the total elapsed time should be less than 6 seconds
 
     @javascript
     Scenario: Check element visibility
@@ -83,3 +84,10 @@ Feature: Browser Feature
     Scenario:
         Given I am on "/browser/elements.html"
         Then i save the value of "today" in the "today" parameter
+
+    Scenario: Waiting for fractions of a second
+        Given I am on "/browser/index.html"
+        And I wait 1.9 seconds
+        And I wait 1.9 seconds
+        And I wait 1.9 seconds
+        Then the total elapsed time should be more than 4 seconds