Skip to content

Commit 7507dbc

Browse files
committed
firewire: core: record card index in tracepoinrts events derived from bus_reset_arrange_template
The asynchronous transmission of phy packet is initiated on one of 1394 OHCI controller, however the existing tracepoints events has the lack of data about it. This commit adds card_index member into event structure to store the index of host controller in use, and prints it. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Sakamoto <[email protected]>
1 parent abbb4bd commit 7507dbc

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

drivers/firewire/core-card.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -222,14 +222,14 @@ static int reset_bus(struct fw_card *card, bool short_reset)
222222
int reg = short_reset ? 5 : 1;
223223
int bit = short_reset ? PHY_BUS_SHORT_RESET : PHY_BUS_RESET;
224224

225-
trace_bus_reset_initiate(card->generation, short_reset);
225+
trace_bus_reset_initiate(card->index, card->generation, short_reset);
226226

227227
return card->driver->update_phy_reg(card, reg, 0, bit);
228228
}
229229

230230
void fw_schedule_bus_reset(struct fw_card *card, bool delayed, bool short_reset)
231231
{
232-
trace_bus_reset_schedule(card->generation, short_reset);
232+
trace_bus_reset_schedule(card->index, card->generation, short_reset);
233233

234234
/* We don't try hard to sort out requests of long vs. short resets. */
235235
card->br_short = short_reset;
@@ -249,7 +249,7 @@ static void br_work(struct work_struct *work)
249249
/* Delay for 2s after last reset per IEEE 1394 clause 8.2.1. */
250250
if (card->reset_jiffies != 0 &&
251251
time_before64(get_jiffies_64(), card->reset_jiffies + 2 * HZ)) {
252-
trace_bus_reset_postpone(card->generation, card->br_short);
252+
trace_bus_reset_postpone(card->index, card->generation, card->br_short);
253253

254254
if (!queue_delayed_work(fw_workqueue, &card->br_work, 2 * HZ))
255255
fw_card_put(card);

include/trace/events/firewire.h

+12-9
Original file line numberDiff line numberDiff line change
@@ -303,36 +303,39 @@ TRACE_EVENT(async_phy_inbound,
303303
);
304304

305305
DECLARE_EVENT_CLASS(bus_reset_arrange_template,
306-
TP_PROTO(unsigned int generation, bool short_reset),
307-
TP_ARGS(generation, short_reset),
306+
TP_PROTO(unsigned int card_index, unsigned int generation, bool short_reset),
307+
TP_ARGS(card_index, generation, short_reset),
308308
TP_STRUCT__entry(
309+
__field(u8, card_index)
309310
__field(u8, generation)
310311
__field(bool, short_reset)
311312
),
312313
TP_fast_assign(
314+
__entry->card_index = card_index;
313315
__entry->generation = generation;
314316
__entry->short_reset = short_reset;
315317
),
316318
TP_printk(
317-
"generation=%u short_reset=%s",
319+
"card_index=%u generation=%u short_reset=%s",
320+
__entry->card_index,
318321
__entry->generation,
319322
__entry->short_reset ? "true" : "false"
320323
)
321324
);
322325

323326
DEFINE_EVENT(bus_reset_arrange_template, bus_reset_initiate,
324-
TP_PROTO(unsigned int generation, bool short_reset),
325-
TP_ARGS(generation, short_reset)
327+
TP_PROTO(unsigned int card_index, unsigned int generation, bool short_reset),
328+
TP_ARGS(card_index, generation, short_reset)
326329
);
327330

328331
DEFINE_EVENT(bus_reset_arrange_template, bus_reset_schedule,
329-
TP_PROTO(unsigned int generation, bool short_reset),
330-
TP_ARGS(generation, short_reset)
332+
TP_PROTO(unsigned int card_index, unsigned int generation, bool short_reset),
333+
TP_ARGS(card_index, generation, short_reset)
331334
);
332335

333336
DEFINE_EVENT(bus_reset_arrange_template, bus_reset_postpone,
334-
TP_PROTO(unsigned int generation, bool short_reset),
335-
TP_ARGS(generation, short_reset)
337+
TP_PROTO(unsigned int card_index, unsigned int generation, bool short_reset),
338+
TP_ARGS(card_index, generation, short_reset)
336339
);
337340

338341
TRACE_EVENT(bus_reset_handle,

0 commit comments

Comments
 (0)